Skip to content

Repin to dpp-core 0.23.0 does not compile #554

Open

Description

@LKSNDRTMLKV

The 0.23.0 repin is the first item in v0.16.0, and every other item there rebases onto it. dpp-core 0.23.0 is not published yet. This issue records what the repin has to change, so the work is ready to start when it is.

What a compile check found

cargo check --workspace --all-targets with the integration features, run on 2026-10-30 against dpp-core main (4c706d2) through a local patch, failed in three crates:

Where Error Core change
dpp-dal/src/pg/repo_operator_config.rs:85 FacilitySnapshot is missing the new identifier field odal-node/dpp-core#494
dpp-integrator/src/domain/validate/battery.rs:241 and dpp-plugin-host/tests/integration.rs:144 BatteryData is missing due_diligence_operator_scope odal-node/dpp-core#509
dpp-integrator/src/domain/battery_template.rs:634 and :663, dpp-integrator/src/handlers/templates.rs:329 mandatory_fields and annex_xiii_requirement now take a BatteryFacts odal-node/dpp-core#509

The check stopped there, so dpp-vault, dpp-node and dpp-resolver were never compiled. The struct literal sites for FacilitySnapshot and ResponsibleOperator in those crates and their tests will need identifier: None as well.

Known from the registry stack

What the repin changes

  • The dpp-* pins in the root Cargo.toml, and dpp-domain and dpp-vc in fuzz/Cargo.toml, move from "0.22.0" to "0.23.0". Regenerate both lockfiles.
  • The compile fixes above. Where a battery has no facts to give, pass BatteryFacts::default(), which core's migration note names, and expect row 19 (dueDiligenceUrl) to answer Undetermined.

After it merges

The drafts in v0.16.0 rebase onto it: #484, then #490 and #487, then #488 and #489, plus #507 and #532. main already uses migrations 0043 and 0044. #487, #488 and #489 add 0043_registry_handle_audit_action, #489 adds 0044_registry_abandoned, and #532 adds 0044_unsold_goods_disclosure. All of them renumber from 0045 in merge order.

Done when

just check and the Docker integration tier pass on the 0.23.0 pins with no .cargo/config.toml present.

Activity

  1. added this to the v0.16.0 milestone on Oct 30, 2026
  2. added
    type/defectSomething published or encoded here is wrong or unbackable now
    urgency/nextBlocks work already scheduled
    surface/registryMoves EU registry enrolment or the unique product identifier
    blocked/upstreamWaiting on a merge chain, a release, or an unpublished standard
    epic/registryEU registry loop: registration, transfers, handles, the local stand-in
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blocked/upstreamWaiting on a merge chain, a release, or an unpublished standardepic/registryEU registry loop: registration, transfers, handles, the local stand-insurface/registryMoves EU registry enrolment or the unique product identifiertype/defectSomething published or encoded here is wrong or unbackable nowurgency/nextBlocks work already scheduled

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions