Repository navigation
test(vault): pin the event supersede publishes - #528
Merged
Merged
Conversation
Signed-off-by: chillin_since_26 <aleksandar.temelkov@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supersedepublishesdpp.passport.superseded, the same event and payload asamend: both routes end insupersede_predecessor, which publishes it. Nothing tested that, and the docs rewrite had come to say the opposite (corrected on #515 and odal-node/dpp-web#38). This adds the test. No code change was needed.Related issue
None filed.
Changes
crates/dpp-vault/tests/continuity_snapshot.rs: aRecordingEventBus, andsupersede_publishes_the_superseded_event, which publishes a passport and a successor declaringsupersedesId, supersedes, and asserts onedpp.passport.supersededevent withpassportId,successorIdandstatus, plus the snapshot reconcile. The harness already drives the realPassportServicewith in-memory ports, so this runs injust testwithout Docker.Checklist
just checkpasses locally, exceptaudit, which fails onmainuntil fix(deps): clear the October RustSec advisories #516 merges.envfiles in the diff