Fix validation errors in Vulkan sample#175
Open
sasamiyatu wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the following changes to fix validation errors:
Allocated
g_render_finished_semaphoresdynamically based on swapchain image count and index it using swapchain image index instead of frame in flight index. See https://docs.vulkan.org/guide/latest/swapchain_semaphore_reuse.html:Removed
VK_DEBUG_UTILS_MESSAGE_TYPE_DEVICE_ADDRESS_BINDING_BIT_EXTfromDebugUtilsMessengerCreateInfoEXTas it requiresVK_EXT_device_address_binding_report:Removed layers from device creation:
Checklist before submitting:
.github/workflows/check.yml(for automatic testing)-vet -strict-style -vet-tabs -disallow-do -warnings-as-errors