[IMP] runbot: remove/replace deprecated BS* classes usage - #1490
Open
pparidans wants to merge 9 commits into
Open
[IMP] runbot: remove/replace deprecated BS* classes usage#1490pparidans wants to merge 9 commits into
pparidans wants to merge 9 commits into
Conversation
pparidans
changed the title
pparidans
changed the title
pparidans
changed the title
The `.table-condensed` class is a legacy holdover from Bootstrap 3. This commit swaps it for Bootstrap's standard `.table-sm` class across all templates and updates the associated custom CSS selectors accordingly.
The `col-xs-*` grid utilities were deprecated in Bootstrap 4 and removed in Bootstrap 5 (replaced by default `col-*` classes). This commit removes the obsolete `col-xs-9` and `col-xs-3` classes from `build_stats.xml`, allowing the default grid and `col-md-*` breakpoints to handle layout scaling cleanly.
In Bootstrap 5, applying `.table-responsive` directly to `<table>` elements is invalid without a wrapper `<div>`. Replaced with `d-block overflow-x-auto` on the affected tables and removed the legacy custom CSS rule.
The `navbar-default` (Bootstrap 3) and `navbar-light` (deprecated in Bootstrap 5.3) classes are obsolete. This commit cleans up these legacy modifier classes.
Remove `.form-inline` (removed in BS5) and cleanup outdated input-group classes (`md-form`, `form-sm`, `form-2`) from `build.xml` and `frontend.xml`.
Replace legacy `.pull-right` classes with Bootstrap 5 `.float-end`. Note that `.pull-right` was previously still functioning only because FontAwesome 4 includes a `.pull-right` (deprecated) helper class in its CSS, masking its removal from Bootstrap.
Clean up remaining Bootstrap 3 legacy classes and markup across templates: - Remove obsolete `.label` class from commit name spans. - Remove redundant `<li class="nav-item divider"/>` elements from navbar items. - Remove redundant `<span class="caret"/>` from dropdown toggles, as Bootstrap 5 handles caret arrows automatically via standard CSS pseudo-elements.
Hardcoded background utility classes like `.bg-white` force a light background and break dark mode support introduced in Bootstrap 5.3. Replacing `.bg-white` with `.bg-body` ensures the sticky header background adapts dynamically to the current color mode theme.
In Bootstrap 5, dropdown menus expect standard HTML list markup (`ul.dropdown-menu` with `li` item wrappers) and clean `.dropdown-item` classes without button utility overrides. This commit: - Wraps dropdown menu containers in `<ul>` and items in `<li>` across templates. - Removes obsolete `.btn .btn-default` classes from dropdown items. - Wraps the GitHub dropdown template call in a `.btn-group` container for proper dropdown alignment.
pparidans
force-pushed
the
19.0-frontend-bs-cleanup-app
branch
from
August 13, 2026 15:30
8501487 to
689006a
Compare
pparidans
marked this pull request as ready for review
August 13, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up deprecated BS3/BS4 classes.
Note: no visual change should be expected.