[REF] runbot: replace jQuery usages with vanilla JS across frontend - #1494
Open
pparidans wants to merge 4 commits into
Open
[REF] runbot: replace jQuery usages with vanilla JS across frontend#1494pparidans wants to merge 4 commits into
pparidans wants to merge 4 commits into
Conversation
pparidans
force-pushed
the
19.0-frontend-no-jquery-app
branch
from
August 17, 2026 07:47
1c9b055 to
8fb36e4
Compare
Replace the jQuery click delegation in `runbot.js` with a native DOM
event listener.
Note: `document.addEventListener` call doesn't need to wait for
DOMContentLoaded event, hence removing the equivalent `$.ready` wrapper
(`$(function () { ... })`).
Remove the global `shifted` variable and jQuery `keyup`/`keydown` event listener in `stats.js`. Shift key detection is now read directly from `event.native.shiftKey` in the Chart.js click callback.
- Replace jQuery DOM creation with native API (i.e. `createElement` and `replaceChildren()`). - Use native `addEventListener` for legend item toggles. - Fix implicit global variable scoping in dataset loop.
With all first-party consumers converted, remove the jQuery asset, vendored sources, and ESLint globals.
pparidans
force-pushed
the
19.0-frontend-no-jquery-app
branch
from
August 20, 2026 08:33
8fb36e4 to
a861b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up remaining jQuery dependencies in
runbot.jsandstats.js:[data-runbot]click handling to native DOM event listeners and drop$.ready.event.native.shiftKeyin Chart.js click events.stats.jsusing native DOM methods (createElement,replaceChildren).