Support PHP 8.5 and test PHP 8.1–8.5 - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5 rejects #[Attribute] on abstract classes, which caused 53 main-suite errors and 33 performance-suite errors. Remove the marker from BaseAttribute; concrete attributes retain their own markers and inheritance.
Expand both workflow matrices to PHP 8.1–8.5 and rerun PR checks when commits are pushed or a PR is reopened.
Validation: both suites finish with zero failures/errors locally on Windows with PHP 8.1.34, 8.2.33, 8.3.33, 8.4.25, and 8.5.10. Each version runs 58 main-suite tests and 45 performance tests. Existing caveats: 15 incomplete main tests, one skipped readonly-class test on PHP 8.1, and eight dependency deprecations on PHP 8.4/8.5.