Skip to content

Add Mago 1.47.4 quality checks without a baseline - #95

Merged
WalterWoshid merged 1 commit into
okapi-web:masterfrom
WalterWoshid:chore/mago-quality
Sep 5, 2026
Merged

Add Mago 1.47.4 quality checks without a baseline#95
WalterWoshid merged 1 commit into
okapi-web:masterfrom
WalterWoshid:chore/mago-quality

Conversation

@WalterWoshid

@WalterWoshid WalterWoshid commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Adds Mago 1.47.4 as a pinned development dependency and gates CI on formatting, linting, static analysis, and callback type-patch regression tests. Source targets PHP 8.1; the test configuration targets PHP 8.2 for the existing readonly fixtures.

The cleanup applies consistent formatting, corrects type declarations and PHPDoc, adds necessary runtime guards, and updates test fixtures. No baseline is created. Two narrowly checked PropertyAccess expectations remain for four diagnostics involving runtime property names; MAGO.md explains their scope. The dependency-injection callback exception is replaced with a generic vendor type patch that preserves default callback validation. Valid callbacks pass and all four invalid callback fixtures are rejected.

Discarded plugin experiments are removed. Performance fixtures now use a shared interface and reflection for construction; loading measurements should only be compared against runs with the same harness. Method-execution measurements are unchanged.

Validation:

@WalterWoshid
WalterWoshid merged commit 0d0fbba into okapi-web:master Sep 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant