Add Mago 1.47.4 quality checks without a baseline - #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Mago 1.47.4 as a pinned development dependency and gates CI on formatting, linting, static analysis, and callback type-patch regression tests. Source targets PHP 8.1; the test configuration targets PHP 8.2 for the existing readonly fixtures.
The cleanup applies consistent formatting, corrects type declarations and PHPDoc, adds necessary runtime guards, and updates test fixtures. No baseline is created. Two narrowly checked PropertyAccess expectations remain for four diagnostics involving runtime property names; MAGO.md explains their scope. The dependency-injection callback exception is replaced with a generic vendor type patch that preserves default callback validation. Valid callbacks pass and all four invalid callback fixtures are rejected.
Discarded plugin experiments are removed. Performance fixtures now use a shared interface and reflection for construction; loading measurements should only be compared against runs with the same harness. Method-execution measurements are unchanged.
Validation: