Run reagent-karma-example karma tests in CI - #18
Merged
Merged
Conversation
Add a test:karma script (compile the :karma build, then karma --single-run) and include it in the example's ci script. The karma config already uses ChromeHeadlessNoSandbox, and the CI matrix runs npm run ci per example, so the browser tests now run on the ubuntu runner (which ships Chrome). e2e (taiko) is left out for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the karma (headless browser) tests to CI for
reagent-karma-example. Node tests already ran; the browser path did not.test:karmascript:shadow-cljs compile karma && karma start --single-run.ciscript, so the existing example CI matrix (npm run ciper example) runs it — no workflow change needed.ChromeHeadlessNoSandbox(--no-sandbox), and GitHub's ubuntu runners ship Chrome, so it runs headless on CI.Verified locally:
npm run ciruns fmt → lint → compile app → node test → karma (3 browser tests), all green.e2e (taiko) is intentionally left out for now — it needs the app built + its own Chromium download + a static server, so it's heavier/flakier. Can add later if wanted.