Clean up reagent-karma-example: drop e2e, rewrite README for npm - #19
Merged
Conversation
The e2e tests were never run in CI (they need the app built, taiko's own Chromium, and a static server). Drop the :e2e shadow build, src/e2e/core.cljs, the e2e npm script, and the taiko/taiko-diagnostics/ serve-handler dependencies. Node and karma tests remain and cover the example. Also fix the stale e2e/yarn wording in the README's scripts section.
Convert all yarn commands to npm, and fix stale content: drop the removed devcards 'cards' section, and correct the format script (npm run fmt via Prettier + prettier-plugin-cljfmt, not zprint-clj).
olecve
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of the
reagent-karma-examplesubproject.Remove unused e2e (taiko) — it was never run in CI (needs the app built, taiko's own Chromium, and a static server):
:e2eshadow build andsrc/e2e/core.cljs.e2enpm script and thetaiko/taiko-diagnostics/serve-handlerdeps (lockfile refreshed).Rewrite the README for npm:
yarncommands tonpm.cards(devcards) section — devcards was already removed.npm run fmtvia Prettier + prettier-plugin-cljfmt, not zprint-clj).Node + karma tests remain and cover the example.
npm run ci(fmt → lint → compile app → node test → karma) passes.