Add Test Coverage: CFT Compound Expression - #101
Closed
simpsont-oci wants to merge 1 commit into
Closed
simpsont-oci wants to merge 1 commit into
simpsont-oci wants to merge 1 commit into
Conversation
Contributor
|
Can you create a branch in this repo and merge all these PRs into that branch (no master)? That way we can run the tests in the branch directly. |
Contributor
Author
|
Sure. I thought this would make it easier to review but I can combine them all in a branch for this repo. |
Contributor
Author
|
See #105 |
Contributor
|
Moved to #105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Existing CFT tests only filter on a key field or a non-key field in isolation. Compound expressions and string-literal filters are untested, and filter-grammar parsing is a known source of cross-vendor divergence.
Description
Adds Test_Cft_2, a compound AND expression combining a key (color) and non-key (shapesize) field, reusing test_size_receivers.