Add Test Coverage: History KEEP_LAST + Depth 1 - #102
Closed
simpsont-oci wants to merge 1 commit into
Closed
simpsont-oci wants to merge 1 commit into
simpsont-oci wants to merge 1 commit into
Conversation
Contributor
|
Moved to #105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KEEP_LAST depth is only tested at 5. Depth 1 ("latest value only") is arguably the most common real-world history setting and forces the writer to GAP superseded samples for RELIABLE readers (an RTPS-protocol path the depth-5 tests don't exercise).
Description
Adds Test_History_2, RELIABLE + KEEP_LAST 1 with a fast writer/slow reader, reusing test_order_w_instances to verify strictly increasing values with expected gaps.