Conversation
There was a problem hiding this comment.
Pull request overview
Adds application sandbox Docker integration tests to the CI integration workflow so the sandbox identity/kernel baseline, startup verifier behavior, and network policy enforcement are exercised automatically alongside existing Docker integration coverage.
Changes:
- Run application sandbox integration tests in CI with
REPLOY_DOCKER_INTEGRATION=1. - Add a dedicated
go testinvocation targeting the sandbox-related Docker integration test set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run application sandbox integration tests | ||
| env: | ||
| REPLOY_DOCKER_INTEGRATION: "1" | ||
| run: >- | ||
| go test -timeout 15m ./internal/dockerdeploy | ||
| -run '^(TestTransientCommandDockerIntegrationEnforcesIdentityAndKernelBaseline|TestApplicationStartupVerifierDockerIntegration|TestApplicationNetworkPolicyDockerIntegration)$' |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96a44c8206
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| go test -timeout 10m ./internal/dockerdeploy | ||
| -run '^(TestPrivateWorkloadEnvironmentDockerIntegrationMasksFilesAndInjectsValues|TestPrivateRuntimeMasksDockerIntegrationProtectTransientContainer|TestPrivateWorkloadEnvironmentRealDockerIsolation)$' | ||
|
|
||
| - name: Run application sandbox integration tests |
There was a problem hiding this comment.
This new integration step changes the CI gate maintainers run across every runtime matrix entry, so it is a test-only change that affects the maintainer workflow; however, the commit contains no fragment under .changes/unreleased/. Add a Changie fragment describing the additional validation gate.
AGENTS.md reference: AGENTS.md:L15-L16
Useful? React with 👍 / 👎.
636f4ef to
c9e1e7a
Compare
3fccdcf to
f3296ed
Compare
07ee4d0 to
e5ee386
Compare
22714ac to
f820dd5
Compare
5d8b961 to
f759536
Compare
5530b55 to
af0085a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Stack created with Sapling. Best reviewed with ReviewStack.