Repository navigation
Conversation
Bring the loader's check-abi.yml in line with the spec repo's loader-integration ABI check, so routine changes stop failing it. - Downgrade Parameter_Changed_Register / Parameter_Changed_Offset to Low. abi-dumper reads the last DWARF location entry, so -Og builds report false register/offset moves. Real breaks still fail via the type, added and removed rules. - Ignore the ZE_API_VERSION_CURRENT bump (scripts/update_ze_api_version.py, copied from the spec repo). - Pin abi-compliance-checker to 2.3 and abi-dumper to 1.4. - Let a reviewer accept a failure with an approval review containing abi-failure-approved. Only approvals from users with write access on the checked head commit count; the review re-runs the check. - Post one PR comment with both results, from a workflow_run companion (check-abi-comment.yml) so it works for fork PRs. - Cache base.dump by base commit, runner image and abi-dumper version. A push to master seeds the cache so new PRs skip the base build. The two jobs are now one matrix job; job names are unchanged. Tested locally with v1.33.1 -> v1.34.0, the case that failed oneapi-src#516: stock 94.9% (2 problems, exit 1); with this change 100% (0 problems, exit 0). Reverse compare (v1.34.0 -> v1.33.1) still fails: 21 problems. Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
rwmcguir
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-abi.ymlfails on normal changes. For example, #516 failed and was merged anyway. This PR removes the false failures, keeps real breaks failing, and makes failures possible to resolve.Parameter_Changed_Register/Parameter_Changed_Offsetrules are now Low. abi-dumper reads the last DWARF location entry, so-Ogbuilds report false moves. Real breaks are still caught by the type, added and removed rules.ZE_API_VERSION_CURRENTbump: this bump is no longer reported.scripts/update_ze_api_version.pycopies the base value into the head dump.2.3and abi-dumper1.4. Before, they came frommasteron every run.abi-failure-approvedaccepts a failure and re-runs the check. It counts only if the reviewer has write access and approved the PR head commit.check-abi-comment.ymlposts it throughworkflow_run, so it also works for fork PRs. It starts after merge.The two jobs are now one matrix job. The job and artifact names are unchanged.
Testing
Local run, v1.33.1 → v1.34.0 (the #516 case):
actionlintpasses.