Make hwloc_targ PATCH_COMMAND idempotent - #1603
Merged
lukaszstolarczuk merged 1 commit intoAug 27, 2026
Merged
Conversation
wenju-he
marked this pull request as ready for review
August 26, 2026 01:41
Contributor
|
thanks @wenju-he LGTM |
bratpiorka
approved these changes
Aug 26, 2026
PatKamin
approved these changes
Aug 26, 2026
PatKamin
left a comment
PatKamin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please fix formatting
bratpiorka
force-pushed
the
PATCH_COMMAND-skip-if-already-applied
branch
from
August 26, 2026 07:53
b7e52af to
4c1a7ba
Compare
Contributor
|
@PatKamin done |
Contributor
|
please rebase on the latest main, for the CI to pass :) |
UPDATE_DISCONNECTED still re-touches the update step's stamp on every build, which invalidates the downstream patch step's stamp even though the source wasn't reset. Since git apply isn't idempotent, this made every incremental build after the first fail with "patch does not apply". Skip re-applying when the patch is already present. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
wenju-he
force-pushed
the
PATCH_COMMAND-skip-if-already-applied
branch
from
August 27, 2026 09:57
4c1a7ba to
f23144b
Compare
Contributor
Author
done |
lukaszstolarczuk
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE_DISCONNECTED still re-touches the update step's stamp on every
build, which invalidates the downstream patch step's stamp even though
the source wasn't reset. Since git apply isn't idempotent, this made
every incremental build after the first fail with "patch does not
apply". Skip re-applying when the patch is already present.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Checklist