Skip to content

Change signature added text #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martenrebane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change signature added text #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RIADigiDoc/Domain/NFC/NFCSessionStringsUtil.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public struct NFCSessionStringsUtil {
customLocalizations(
pinName: pinName,
step4Message: localize("Signing in progress", []),
successMessage: localize("Signature added", []),
successMessage: localize("Container signed successfully", []),
courierCardErrorMessage: localize("ID card courier must activate to sign", [])
)
}
Expand Down
36 changes: 18 additions & 18 deletions RIADigiDoc/Supporting files/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,6 +1187,24 @@
}
}
},
"Container signed successfully" : {
"comment" : "Shown as Toast when signing succeeds",
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Container signed successfully!"
}
},
"et" : {
"stringUnit" : {
"state" : "translated",
"value" : "Ümbrik edukalt allkirjastatud!"
}
}
}
},
"Container signing" : {
"comment" : "Signing view container files title (unsigned)",
"extractionState" : "manual",
Expand Down Expand Up @@ -7954,24 +7972,6 @@
}
}
},
"Signature added" : {
"comment" : "Shown as Toast when signing succeeds",
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Signature added"
}
},
"et" : {
"stringUnit" : {
"state" : "translated",
"value" : "Allkiri lisatud"
}
}
}
},
"Signature detail invalid reason" : {
"comment" : "Signature detail",
"extractionState" : "manual",
Expand Down
8 changes: 4 additions & 4 deletions RIADigiDoc/UI/Component/Container/Signing/NFC/NFCView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ struct NFCView: View {
}
}

private var signatureAddedMessage: String {
languageSettings.localized("Signature added")
private var containerSignedMessage: String {
languageSettings.localized("Container signed successfully")
}

private var extendingSignaturesFailedMessage: String {
Expand Down Expand Up @@ -491,9 +491,9 @@ struct NFCView: View {
AccessibilityUtil.announceMessage(extendingSignaturesFailedMessage)
}
} else {
Toast.show(signatureAddedMessage, type: .success)
Toast.show(containerSignedMessage, type: .success)
if voiceOverEnabled {
AccessibilityUtil.announceMessage(signatureAddedMessage)
AccessibilityUtil.announceMessage(containerSignedMessage)
}
}

Expand Down
2 changes: 1 addition & 1 deletion RIADigiDoc/ViewModel/Signing/MobileId/MobileIdViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ class MobileIdViewModel: MobileIdViewModelProtocol, Loggable {
let isLTAEnabled = await dataStore.getIsDefaultLTAEnabled()
do {
let extendedContainer = try await updatedContainer.extendSignature(isLTAEnabled)
mobileIdSuccessMessageKey = "Signature added"
mobileIdSuccessMessageKey = "Container signed successfully"
return extendedContainer
} catch {
MobileIdViewModel.logger().error("Unable to extend signature (Mobile-ID): \(error)")
Expand Down
2 changes: 1 addition & 1 deletion RIADigiDoc/ViewModel/Signing/SmartId/SmartIdViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class SmartIdViewModel: SmartIdViewModelProtocol, Loggable {
let isLTAEnabled = await dataStore.getIsDefaultLTAEnabled()
do {
let extendedContainer = try await updatedContainer.extendSignature(isLTAEnabled)
smartIdSuccessMessageKey = "Signature added"
smartIdSuccessMessageKey = "Container signed successfully"
return extendedContainer
} catch {
SmartIdViewModel.logger().error("Unable to extend signature (Smart-ID): \(error)")
Expand Down
2 changes: 1 addition & 1 deletion RIADigiDocTests/ViewModel/Signing/MobileId/MobileIdViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ struct MobileIdViewModelTests {

#expect(result != nil)
#expect(viewModel.controlCode == "1234")
#expect(viewModel.mobileIdSuccessMessageKey == "Signature added")
#expect(viewModel.mobileIdSuccessMessageKey == "Container signed successfully")
}

@Test
Expand Down
Loading