Skip to content

Fix signing error message for Latvia and Lithuania #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martenrebane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix signing error message for Latvia and Lithuania #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/SmartIdLib/Sources/SmartIdLib/Networking/Handler/ResponseHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ struct ResponseHandler: ResponseHandlerProtocol {
switch statusCode ?? -1 {
case 400:
throw SmartIdError.incorrectParameters
case 401:
case 401, 403:
throw SmartIdError.invalidAccessRights
case 404:
throw SmartIdError.accountNotFound
Expand Down
9 changes: 9 additions & 0 deletions Modules/SmartIdLib/Tests/SmartIdLibTests/Networking/Handler/ResponseHandlerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,15 @@ struct ResponseHandlerTests {
}
}

@Test
func handleNetworkError_throwsInvalidAccessRightsWhenUnacceptableStatusCode403Returned() {
let afError = AFError.responseValidationFailed(reason: .unacceptableStatusCode(code: 403))

#expect(throws: SmartIdError.invalidAccessRights) {
try handler.handleNetworkError(afError, statusCode: 403)
}
}

@Test
func handleNetworkError_throwsIncorrectParametersWhenUnacceptableStatusCode400Returned() {
let afError = AFError.responseValidationFailed(reason: .unacceptableStatusCode(code: 400))
Expand Down
Loading