Skip to content

Ehnace logging for yezzey vacuum even more #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reshke merged 1 commit into from
Jun 3, 2026
Merged

Ehnace logging for yezzey vacuum even more #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/proc/interaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,8 +635,11 @@ func ProcessDeleteObsolete(msg message.DeleteObsoleteMessage, s storage.StorageI
return err
}
if first_backup_lsn == ^uint64(0) {
ylogger.Zero.Error().Err(err).Msg("Failed to acquire first backup LSN")
return fmt.Errorf("wal-g backups required for consistent deleting")
}

ylogger.Zero.Info().Uint64("lsn", first_backup_lsn).Msg("first backup LSN")
conn, err := dh.GetConnectToDatabase(msg.Port, msg.DBName)
if err != nil {
ylogger.Zero.Error().Err(err).Msg("ProcessDeleteObsolete: get connection")
Expand All @@ -645,7 +648,7 @@ func ProcessDeleteObsolete(msg message.DeleteObsoleteMessage, s storage.StorageI
defer func() { _ = conn.Close() }()

for str, v := range ei {
ylogger.Zero.Debug().Str("delete candidate", str).Uint64("expire lsn", v).Uint64("first backup lsn", first_backup_lsn).Msg("checking lsn")
ylogger.Zero.Info().Str("delete candidate", str).Uint64("expire lsn", v).Uint64("first backup lsn", first_backup_lsn).Msg("checking lsn")
if v >= first_backup_lsn {
continue
}
Expand Down Expand Up @@ -682,8 +685,7 @@ func ProcessDeleteObsolete(msg message.DeleteObsoleteMessage, s storage.StorageI

continue
}
ylogger.Zero.Debug().Str("delete candidate", str).Msg("deleted successfully")

ylogger.Zero.Info().Str("delete candidate", str).Msg("deleted successfully")
}
return nil
}
Expand Down
Loading