Skip to content

Diagram python op#191

Draft
aaronchongth wants to merge 6 commits into
python_opfrom
diagram-python-op
Draft

Diagram python op#191
aaronchongth wants to merge 6 commits into
python_opfrom
diagram-python-op

Conversation

@aaronchongth
Copy link
Copy Markdown
Member

@aaronchongth aaronchongth commented May 5, 2026

New feature implementation

Related to #167

Implemented feature

  • script environment manager
    • create, edit, delete script environments
    • highlight script nodes using a specific script environment
    • prevents deletion of script environments if script nodes are using the environment
    • script editor (added react-codemirror as dependency)
  • script node
    • selection of script environment
    • added exporting and connections
  • added a context for handling notifications, to provide some feedback when users create, edit or delete script environments. We can migrate error notifications to this, in the future. Keeping this PR easier to review for now
  • added script to diagram operation (this is only temporary, upstream changes will probably take care of this, so we can remove this from this PR)

Discussion points

  • once we have schemas for the script builders, we can
    • get the designated scripting language
    • validate the config properly based on the schema
    • get the default script (code), for now I have copied the example from the python operation rust code
  • only supporting python for now, as each language support is an additional dep

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by: Gemini Flash

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@mxgrey mxgrey added this to PMC Board May 5, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in PMC Board May 5, 2026
@aaronchongth aaronchongth marked this pull request as draft May 5, 2026 01:15
@aaronchongth aaronchongth moved this from Inbox to In Progress in PMC Board May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants