Use GCC image for Linux builds and simplify workflow#801
Conversation
This fixes #800 by making changes to the Conan+Linux CI workflow. The official Conan Center docker image we were using has now been deprecated (all of them have), so I have switched to using the official GCC image instead. This required a GCC version upgrade. The oldest supported version is 12, but I went with 14 so we can stay on the same version for a while. (GCC 15 is the newest, at the time of writing.) I also replaced the roundabout process we had of generating our own Docker image to using Github Actions' built-in facilities for choosing an image. This also fixes #798 by updating the Conan options syntax for both Conan workflows.
|
It looks good to me. No suggested changes. |
|
Any comments from @restenb or @davidhjp01 regarding the (quite significant) GCC version bump? Are all ok with this? |
|
I've made a similar change in the CLI repo, by the way. See open-simulation-platform/cosim-cli#122. |
kyllingstad
changed the title
I've implemented the same change as in open-simulation-platform/libcosim#801, i.e., switching from building a custom container image to using a standard GCC image. I've also updated actions/checkout and actions/upload-artifacts to newer versions.
|
I created a separate PR to this branch that uses cmake v4 - #802, which also depends proxy-fmu PR - open-simulation-platform/proxy-fmu#104 |
LGTM, just made two additional PR to support cmake v4. |
|
Is there anything in this PR that triggered the need to upgrade to CMake 4, or is it an independent issue? |
Not from PR, we just updated our code base to C++20 minimum and it triggered a chain of updates that required for us to use cmake v4. But since currently master branch does not build, just used this branch as a base instead for the cmake upgrade. |
* Enhance CMake configuration for Debug builds and improve error logging messages * Refactor CMake configuration to ensure Release dependencies are used for all build types * Set CMakeDeps configuration to "Release" for Windows builds * Update CMake configuration and dependencies for improved compatibility * Enhance CMake configuration in CI and conanfile for improved dependency management * Revert "Updated" This reverts commit 071dcd9. * Remove commented-out configuration mappings in CMakeLists.txt * Updated * Reverted back conanfile.py changes * Remove cmake installation from pipx in ci-conan.yml * Update proxyfmu dependency version to 0.4.2 in conanfile.py * Remove cmake installation from ci-conan.yml
3 participants
This fixes #800 by making changes to the Conan+Linux CI workflow. The official Conan Center docker image we were using has now been deprecated (all of them have), so I have switched to using the official GCC image instead. This required a GCC version upgrade. The oldest supported version is 12, but I went with 14 so we can stay on the same version for a while. (GCC 15 is the newest, at the time of writing.)
I also replaced the roundabout process we had of generating our own Docker image to using Github Actions' built-in facilities for choosing an image.
This also fixes #798 by updating the Conan options syntax for both Linux and Windows workflows.