Add support for batching in PeriodicMetricReader by psx95 · Pull Request #8296 · open-telemetry/opentelemetry-java

psx95 · 2026-04-15T01:18:20Z

This PR adds support for configuring setMaxExportBatchSize on the PeriodicMetricReader that sets the maximum number of metric data points to be sent in a single export call.

If the number of metric data points (across Collection<MetricData>) scheduled to be export exceeds the maxExportBatchSize, the data points organized in batches and sent over multiple export calls.

These changes do not modify the current timeout behavior, which is still per export call.

Fix #8245

codecov · 2026-04-15T14:19:24Z

Codecov Report

❌ Patch coverage is 90.84507% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.82%. Comparing base (b87fa99) to head (b6edfb7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...try/sdk/metrics/internal/SdkMeterProviderUtil.java	0.00%	8 Missing ⚠️
...emetry/sdk/metrics/export/MetricExportBatcher.java	96.93%	1 Missing and 2 partials ⚠️
...metry/sdk/metrics/export/PeriodicMetricReader.java	93.75%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8296      +/-   ##
============================================
- Coverage     90.82%   90.82%   -0.01%     
- Complexity     7927     7944      +17     
============================================
  Files           895      896       +1     
  Lines         23872    24010     +138     
  Branches       2378     2390      +12     
============================================
+ Hits          21681    21806     +125     
- Misses         1446     1456      +10     
- Partials        745      748       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

# Conflicts: # sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/MetricExportBatcher.java

…ropagation' into lane-a-pr-8296 # Conflicts: # sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/export/PeriodicMetricReaderTest.java Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

…propagation Fix batched forceFlush failure and make batching linear

jack-berg

Couple of comments, but looks pretty good!

psx95 · 2026-05-01T15:52:33Z

Addressed all the feedback on this PR and added a Changelog entry as well.

The CI Build failure on Windows for Java 11 looks like a transient error and might be fixed upon retrying.

psx95 force-pushed the issue-8245 branch from acad099 to 8153388 Compare April 15, 2026 13:40

otelbot Bot added the api-change Changes to public API surface area label Apr 15, 2026

psx95 force-pushed the issue-8245 branch from 9d84747 to 03364b5 Compare April 15, 2026 18:17

psx95 marked this pull request as ready for review April 15, 2026 18:42

psx95 requested a review from a team as a code owner April 15, 2026 18:42

dashpole reviewed Apr 15, 2026

View reviewed changes

dashpole requested a review from Copilot April 16, 2026 00:47

Copilot started reviewing on behalf of dashpole April 16, 2026 00:48 View session

This comment was marked as outdated.

Sign in to view

psx95 requested a review from Copilot April 16, 2026 15:59

Copilot started reviewing on behalf of psx95 April 16, 2026 16:00 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/MetricExportBatcher.java Outdated

Comment thread sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/export/MetricExportBatcherTest.java Outdated

dashpole requested a review from Copilot April 16, 2026 16:30

Copilot started reviewing on behalf of dashpole April 16, 2026 16:31 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/PeriodicMetricReader.java Outdated

Comment thread sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/export/MetricExportBatcherTest.java

psx95 added 14 commits April 19, 2026 17:34

WIP: Add metrics batcher in the SDK

91b087c

Allow exporting metricData batches

9534dea

Make existing tests compatible with changes

70d4e15

Add docs and update existing tests

6b97875

Fix MetricExportBatcher logic and add tests

b2b78c3

Add support for EXPONENTIAL_HISTOGRAM and SUMMARY data types

40226ae

Fix metrics checkstyle issue

af9fad2

Add missing generated diff files

3c3bc1a

Update unit tests for enhanced coverage

7b3feb8

Add unit tests for PeriodicMetricReader

0083b54

Fix checkstyle issues

1b3ad77

Clean up inline code comments

5e18a7c

Fix bug for miscalculating remaining capacity of a batch

a5b0120

Add missing Javadoc for public facing API

1751b57

psx95 added 12 commits April 24, 2026 15:06

Update unit tests for enhanced coverage

6027e52

Add unit tests for PeriodicMetricReader

dc322fd

Fix checkstyle issues

8027bdd

Clean up inline code comments

549c08f

Fix bug for miscalculating remaining capacity of a batch

1da7d24

Add missing Javadoc for public facing API

628a35f

Refactor logic in prepareExportBatches to remove redundancy

d080d1d

Address comment about defensive copy for original point sublist

51c5297

Prevent copying MetricData for 0 points

fc08f5b

Add test case to verify there are no batches with empty metric points

d393c96

Switch to sequential export

56c9385

Add tests to verify sequential export for PeriodicMetricReader

d87f785

psx95 force-pushed the issue-8245 branch from e90ab8d to d87f785 Compare April 24, 2026 15:06

zeitlinger and others added 5 commits April 27, 2026 07:49

Resolve lane A review follow-ups

55c10c7

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Merge remote-tracking branch 'psx95/issue-8245' into lane-a-pr-8296

19546a6

# Conflicts: # sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/MetricExportBatcher.java

Merge remote-tracking branch 'gregor/gregor/8296-forceflush-failure-p…

2628fe4

…ropagation' into lane-a-pr-8296 # Conflicts: # sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/export/PeriodicMetricReaderTest.java Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Restore forceFlush doRun failure handling

8aff51d

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Merge pull request #5 from zeitlinger/gregor/8296-forceflush-failure-…

3bfb526

…propagation Fix batched forceFlush failure and make batching linear

jack-berg reviewed Apr 29, 2026

View reviewed changes

psx95 added 4 commits April 30, 2026 20:35

Make setMaxExportBatchSize package private, use SdkMeterProviderUtil

4c2b9bd

Use LogCapturer extension for log assetion in tests

2e9efb7

Simplify the batchMetrics function

b3e4db7

Update the apidiffs

f4e996f

otelbot Bot removed the api-change Changes to public API surface area label Apr 30, 2026

psx95 added 2 commits April 30, 2026 21:59

Extract batch export logic to helper function

79adac4

Merge branch 'main' into issue-8245

e8d041d

jack-berg reviewed May 1, 2026

View reviewed changes

Comment thread sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/MetricExportBatcher.java Outdated

Make batchMetrics static

b6edfb7

github-actions Bot mentioned this pull request May 4, 2026

Pull Request Dashboard #8366

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for batching in PeriodicMetricReader#8296

Add support for batching in PeriodicMetricReader#8296
psx95 wants to merge 55 commits intoopen-telemetry:mainfrom
psx95:issue-8245

psx95 commented Apr 15, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

jack-berg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psx95 commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

psx95 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psx95 commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

psx95 commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 15, 2026 •

edited

Loading