Skip to content

Fix global tox test matrix failures and linters #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
royrhea wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix global tox test matrix failures and linters #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07e5aed
Fix global tox test matrix failures and linters
royrhea Aug 9, 2026
e2d2cd5
fix: resolve review comments for pytest.ini loop scope, test_env excl…
royrhea Aug 17, 2026
2f38666
Merge branch 'main' into fix-test-matrix-linters
royrhea Aug 17, 2026
4a8aca0
Merge branch 'main' into fix-test-matrix-linters
royrhea Aug 19, 2026
fa62571
Merge branch 'main' into fix-test-matrix-linters
royrhea Aug 19, 2026
cefdd36
Merge branch 'main' into fix-test-matrix-linters
royrhea Aug 20, 2026
155cc78
Merge branch 'main' into fix-test-matrix-linters
royrhea Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions instrumentation/opentelemetry-instrumentation-genai-agno/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ include = ["/src", "/tests"]
[tool.hatch.build.targets.wheel]
packages = ["src/opentelemetry"]

[tool.pytest.ini_options]
testpaths = ["tests"]

[tool.towncrier]
directory = ".changelog"
filename = "CHANGELOG.md"
Expand Down
6 changes: 0 additions & 6 deletions instrumentation/opentelemetry-instrumentation-genai-anthropic/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ include = ["/src", "/tests", "/examples"]
[tool.hatch.build.targets.wheel]
packages = ["src/opentelemetry"]

[tool.pytest.ini_options]
testpaths = ["tests"]
markers = [
"conformance: GenAI semconv conformance scenario (run via the *-conformance tox envs)",
]

[tool.towncrier]
directory = ".changelog"
filename = "CHANGELOG.md"
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/opentelemetry-instrumentation-genai-claude-agent-sdk/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ include = ["/src", "/tests", "/examples"]
[tool.hatch.build.targets.wheel]
packages = ["src/opentelemetry"]

[tool.pytest.ini_options]
testpaths = ["tests"]

[tool.towncrier]
directory = ".changelog"
filename = "CHANGELOG.md"
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/opentelemetry-instrumentation-genai-crewai/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ include = ["/src", "/tests"]
[tool.hatch.build.targets.wheel]
packages = ["src/opentelemetry"]

[tool.pytest.ini_options]
testpaths = ["tests"]

[tool.towncrier]
directory = ".changelog"
filename = "CHANGELOG.md"
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/opentelemetry-instrumentation-genai-llama-index/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ include = ["/src", "/tests"]
[tool.hatch.build.targets.wheel]
packages = ["src/opentelemetry"]

[tool.pytest.ini_options]
testpaths = ["tests"]

[tool.towncrier]
directory = ".changelog"
filename = "CHANGELOG.md"
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/opentelemetry-instrumentation-genai-smolagents/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ include = ["/src", "/tests"]
[tool.hatch.build.targets.wheel]
packages = ["src/opentelemetry"]

[tool.pytest.ini_options]
testpaths = ["tests"]

[tool.towncrier]
directory = ".changelog"
filename = "CHANGELOG.md"
Expand Down
3 changes: 3 additions & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@
addopts = -rfE -v
log_cli = true
log_cli_level = warning
asyncio_default_fixture_loop_scope = function

@lmolkova lmolkova Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't reach the packages that define their own [tool.pytest.ini_options]. pytest stops its config lookup at the package pyproject.toml and never reads root pytest.ini. Affected: anthropic, agno, crewai, smolagents, llama-index, claude-agent-sdk. Those envs will keep emitting the warning.

Simplest fix: drop the [tool.pytest.ini_options] blocks from those six pyproject.tomls so root config applies everywhere. Otherwise the setting has to be duplicated into each.

markers =
conformance: GenAI semconv conformance scenario (run via the *-conformance tox envs)
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ commands_pre =
sh -c "sudo apt update -y && sudo apt install --assume-yes shellcheck"

commands =
sh -c "find {toxinidir} -name \*.sh | xargs shellcheck --severity=warning"
sh -c "find {toxinidir} -type f -name '*.sh' -not -path '*/.tox/*' -not -path '*/.venv*/*' -not -path '*/venv*/*' -print0 | xargs -0 shellcheck --severity=warning"

[testenv:{precommit,ruff}]
basepython: python3
Expand Down