Skip to content

Add return type annotations to ConsoleLogRecordExporter methods #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Matthew-Selvam wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add return type annotations to ConsoleLogRecordExporter methods #5718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21a1b87
Add return type annotations to ConsoleLogRecordExporter methods
MatthewSelvam Oct 1, 2026
c9696b5
Re-run checks after CLA authorization
Matthew-Selvam Oct 5, 2026
c5e395e
Merge branch 'main' into add-console-log-record-exporter-return-types
lzchen Oct 6, 2026
73279d5
fix: rename changelog entry from 5713 to 5718
Matthew-Selvam Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5718.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-sdkc: add return type annotations to `ConsoleLogRecordExporter.__init__`, `export`, and `shutdown`
6 changes: 3 additions & 3 deletions opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,17 +148,17 @@ def __init__(
self,
out: IO = sys.stdout,
formatter: Callable[[ReadableLogRecord], str] = lambda record: record.to_json() + linesep,
):
) -> None:
self.out = out
self.formatter = formatter

def export(self, batch: Sequence[ReadableLogRecord]):
def export(self, batch: Sequence[ReadableLogRecord]) -> LogRecordExportResult:
for log_record in batch:
self.out.write(self.formatter(log_record))
self.out.flush()
return LogRecordExportResult.SUCCESS

def shutdown(self):
def shutdown(self) -> None:
pass

def force_flush(self, timeout_millis: int = 30000) -> bool:
Expand Down
Loading