Skip to content

Request PR write permission for guidance comments#23

Merged
maryliag merged 1 commit into
open-telemetry:mainfrom
trask:fix-pr-dashboard-guidance-token-permission
Jun 26, 2026
Merged

Request PR write permission for guidance comments#23
maryliag merged 1 commit into
open-telemetry:mainfrom
trask:fix-pr-dashboard-guidance-token-permission

Conversation

@trask

@trask trask commented Jun 26, 2026

Copy link
Copy Markdown
Member

Request Pull requests write permission when minting the dashboard app token for the review-guidance job, matching the updated GitHub App permission. Update the webhook setup docs to document that PR conversation guidance comments require Pull requests read and write access.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the post-review-guidance job's GitHub App token with the permissions actually required to post PR conversation guidance comments. The post-review-guidance job uses a minted GitHub App installation token to read existing PR comments and post a guidance comment via the issues comments REST endpoint. For GitHub App tokens, commenting on a pull request through that endpoint requires pull_requests: write (not just issues: write), so the prior read scope would fail. The documentation is updated to reflect this requirement.

Changes:

  • Upgrade permission-pull-requests from read to write for the post-review-guidance token.
  • Update WEBHOOK_SETUP.md to document that PR conversation guidance comments require Pull requests: read and write, including the permission table rows and rationale paragraph.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/pull-request-dashboard-repo.yml Grants the review-guidance app token pull_requests: write so it can post PR conversation comments.
.github/scripts/pull-request-dashboard/WEBHOOK_SETUP.md Updates the App permission list, rationale table, and summary to state that posting guidance comments needs Pull requests: read and write.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trask trask marked this pull request as ready for review June 26, 2026 21:45
@trask trask requested a review from a team as a code owner June 26, 2026 21:45
@maryliag maryliag merged commit bec2e81 into open-telemetry:main Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants