ci: drop pull_request.paths for required-check safety#12
Merged
Conversation
GitHub never creates a check run when on.pull_request.paths excludes a PR, so workflows pinned as required checks would never report and auto-merge would stall. Strip pull_request.paths from this repo's own actionlint self-trigger and from every "Recommended caller stanza" documented in the reusables (actionlint, hadolint, dclint, php-composer-script) so consumers copy the safe pattern. push.paths is unchanged - post-merge re-runs on main still benefit from filtering, and post-merge runs are not required checks. See ocemr-docs reference/github-actions.md "Required Checks and paths: Filters" for the full rationale. Refs openCoreEMR/toolbox#24 Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub never creates a check run when `on.pull_request.paths` excludes a PR, so any reusable promoted to a required status check on its caller would stall auto-merge indefinitely. See ocemr-docs reference/github-actions.md "Required Checks and `paths:` Filters" (openCoreEMR/ocemr-docs#83) for the full rationale.
Existing pinned-tag callers (`@0.0.4` etc.) are unaffected; this only changes future copies of the recommended stanza and the self-test on this repo.
Part of openCoreEMR/toolbox#24.