Skip to content

fix: pass sketch-templater env var properly#892

Open
scheidtdav wants to merge 2 commits intodevfrom
fix/sketch-templater-env
Open

fix: pass sketch-templater env var properly#892
scheidtdav wants to merge 2 commits intodevfrom
fix/sketch-templater-env

Conversation

@scheidtdav
Copy link
Copy Markdown
Member

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

I noticed this message in the server logs recently:

Invalid or missing ingressDomain

After a quick check, it seems like the cfg for the templater was just wrong.
Please confirm.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@scheidtdav scheidtdav requested a review from umut0 April 22, 2026 14:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.17% 1768 / 2556
🔵 Statements 67.51% 1837 / 2721
🔵 Functions 69.46% 364 / 524
🔵 Branches 56.26% 948 / 1685
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/routes/api.boxes.$deviceId.script.ts 73.07% 40% 80% 73.07% 45-51, 74-83, 91-105
Generated in workflow #2441 for commit 354950b by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@umut0 umut0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. fixes the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants