feat(console): collapse Activity/MCP/Config into a Debug drawer (slice 6/6) - #89
Merged
Merged
Conversation
…e 6/6) ADR #83 Part D / §7.6: Activity, MCP · oab-mcp, and Config (cluster / profile / region) drop off the top-level tab strip and collapse into one secondary Debug drawer that slides over the right edge, opened by a `[⚙]` from either the Fleets screen (per-row, scoped to that fleet, 7.2) or the Fleet detail header (scoped to the active fleet, 7.3). Their internals are unchanged — same panes, same tab switch inside the drawer — only their standing in the top-level navigation moves. Compose is the one thing left outside the drawer: it's now always visible in its own section (nothing left to tab away from, since the other three moved) rather than a fourth peer tab. Fixes two duplicate-id bugs of the same class as #82, both reintroduced by slice 1 and only surfaced now that this code is touched again: `id="config"` collided between the Fleets-screen mount and the bottom Config pane (`getElementById("config")` always resolved to the Fleets screen — the debug Config tab never showed the form it should have), and `id="cfg-save"` collided between the fleets.toml/ registry TOML editor's Save button and the Config pane's own submit button (`config.ts`'s save-disable logic was wired to the wrong button). The Config pane's ids are now `debug-config` / `debug-cfg-save`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 6/6 of console-navigation-ia ADR (#83) — usercron
adr83-implrunbook, per §7.6.What
Activity,MCP · oab-mcp, andConfig(cluster/profile/region) come off the top-level#tabsstrip and collapse into one secondary Debug drawer (#debug-drawer, slide-over from the right edge) — Part D: "implementation-detail surfaces... not part of the deploy/manage/chat journey."[⚙]:fleetButton()now renders a.fleets-rowwrapper (select-button + gear as siblings, not nested buttons) instead of one giant row-button.#debug-tabsinstead of the old top-level#tabs), same "flag on new lines while hidden" indicator.Incidental bug fixes (same class as #82, both reintroduced by slice 1)
Found while touching this code again for the drawer move — not new work, but worth flagging since they were silent:
id="config"collision: the Fleets-screen mount (<section id="config" class="config-wrap">) and the bottom Config pane both usedid="config".main.ts'sdocument.getElementById("config")always resolved to the first match (the Fleets screen) — so the Config tab panemain.tswas togglinghiddenon was never the one with the actual form. Renamed the pane todebug-config.id="cfg-save"collision: the fleets.toml/registry TOML editor's Save button and the Config pane's own submit button both usedid="cfg-save".config.ts's save-disable-while-saving logic was wired to the wrong button (the editor's, not its own). Renamed todebug-cfg-save.Verification
tsc --noEmit— cleanvitest run— 107/107 passing (2 new/updated inrender.test.tscovering the per-row and per-fleet-detail gear wiring)vite build— cleanProgress table: this is slice 6/6 — 1–6 all land after this merges. Runbook's step 6/7 (self-review pass across all six slices together) is next.
🤖 Generated by Orca (
ecs-claude), usercronadr83-impl.