Repository navigation
Conversation
|
Thanks for the toolkit. Before merge, please show the selected action's source and precedence before execution, make invalid-override/fallback behavior explicit, and document permissions and file/data boundaries in the packaged README. Add isolated tests for overrides, malformed configuration, strict selection, and safe catalog writes. Required CI and final CDE review are still needed. |
|
Thanks for the review. I pushed The chosen failure boundary is deliberate: malformed or unreadable action files block configured execution because their intended overrides cannot be identified. A parseable invalid variant blocks its strict selector and ambiguous selection of that action name, while unrelated actions and exact valid sibling selectors remain available. Perform shows the latest defining file and applied source order before executing the final rendered prompt. Its Python scripts still do not execute configured actions. Local |
Summary
Add Perform Action Toolkit as an explicitly invoked, local Codex skill. This review revision proposes package
0.4.6, bringing the original0.4.4contribution forward to the current source package baseline (0.4.5) before applying the review changes.Perform discovers bundled, system, user, and repository action JSON; selects an exact action variant; binds declared variables; and shows the final prompt before Codex executes it. The bundled Python scripts use only the standard library and do not execute configured actions themselves. The manifest retains explicit
$toolkit:performstarter prompts and the skill disables implicit invocation.Review response
tests/toolkit/exercise source precedence, malformed configuration, invalid overrides, strict selection, and safe catalog writes from a cold copied package. The npm master lists each integration test explicitly. No configured action or external service is used by these tests.Verification
npm run test:toolkit— passed, 9 Node tests.npm run validate:marketplaceandnpm run validate— passed.git diff --check— passed.ajvdevelopment dependency is absent from this clean clone. Required upstream CI remains authoritative for that gate.Plugin impact
The selected action definition and active Codex session determine which files, local tools, or network destinations execution may access. Perform has no hosted service, plugin-owned account, authentication flow, telemetry collector, credential store, or external data store. The optional
codex-performcompanion is not part of this plugin package. Direct variable values are process arguments and should be nonsecret references rather than secret contents.Please review the source/precedence display and fail-closed override behavior alongside the isolated tests. This PR is still a pre-merge community contribution; it does not publish a source-repository release or update already published directory listings.