Mark config as changed when entering raw mode#3
Merged
fullstackjam merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
hasChanges excluded rawJson edits because captureSnapshot() only reads visual editor state. Adding rawMode to the derived check keeps the save button active whenever the raw textarea is open. https://claude.ai/code/session_01BfBFGMfN6H4FbsrMREGTJ4
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the change detection logic in ConfigEditor to properly track when the user enters raw mode, ensuring the config is marked as having unsaved changes.
Key Changes
hasChangesderived state to includerawModeas a conditionImplementation Details
The
hasChangesflag now evaluates totruewhen:isNew)This change ensures users are prompted to save their changes when they've switched to raw mode, even if they haven't modified the underlying configuration content.
https://claude.ai/code/session_01BfBFGMfN6H4FbsrMREGTJ4