Add efeature ecode mapping - #23
Open
darshanmandge wants to merge 2 commits into
Open
Conversation
darshanmandge
commented
Jul 17, 2026
darshanmandge
commented
Collaborator
- Introduces mapping from ecode names to their valid eFEL features
darshanmandge
force-pushed
the
features_per_ecode
branch
from
July 17, 2026 15:49
52df1b6 to
770c7b3
Compare
darshanmandge
marked this pull request as ready for review
July 20, 2026 06:20
AurelienJaquier
previously approved these changes
Jul 21, 2026
AurelienJaquier
left a comment
AurelienJaquier
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
I am just wondering if it is useful to have voltage_base for each protocol? Since it does not depend on the amplitude, if several protocols are used, it will give more weight to the RMP in the optmisation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.