feat: exclude closed jobs from activity references#764
Open
anonymoususer72041 wants to merge 3 commits into
Open
feat: exclude closed jobs from activity references#764anonymoususer72041 wants to merge 3 commits into
anonymoususer72041 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the add activity / schedule event flows for Contacts and Candidates so that the Regarding job reference dropdown excludes job orders from the configured Closed status group.
Instead of only allowing jobs from the Open status group, the filtering now excludes Closed-group statuses. This keeps Pre-Open job orders such as Upcoming and Lead available, while hiding Closed, Canceled or other statuses configured as closed.
The change adds a central closed job order status SQL helper and uses it from the Contact and Candidate activity reference queries.
The existing activity edit AJAX flow is intentionally left unchanged.
Motivation
When creating new activities, the Regarding dropdown should focus on current job orders that are still relevant for new activity logging. Closed job orders are no longer current references in that context and can make the selection unnecessarily noisy.
This is also related to #361.