refactor: normalize install schema snapshot formatting and nullable definitions#773
Open
anonymoususer72041 wants to merge 4 commits into
Open
Conversation
anonymoususer72041
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the install schema SQL definitions by normalizing the generated schema snapshot and aligning nullable column declarations between fresh installs and upgraded installations.
The schema snapshot in
db/cats_schema.sqlis updated to remove obsolete generator comments, use consistent SQL keyword and spacing style and omit redundant explicitDEFAULT NULLdeclarations for columns that are already nullable. These changes are intended to make the snapshot easier to read and compare without changing the effective nullable behavior of the affected columns.The install upgrade path in
modules/install/Schema.phpis updated with matchingALTER TABLE ... MODIFY ...statements so existing installations converge on the same column definitions as fresh installs.