refactor: run security visibility tests without JavaScript#776
Open
anonymoususer72041 wants to merge 1 commit into
Open
Conversation
anonymoususer72041
changed the title
Contributor
Author
|
Seems like the testing is already ~2 minutes faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary
@javascripttags from security visibility Behat scenarios that only verify server-rendered page content and access-level visibility.The
@javascripttag is intentionally kept forCalendar module visibilityandJob Order Show page visibility, because validation showed that these scenario outlines still require the JavaScript/Selenium session.This keeps the security visibility coverage unchanged while allowing most of these scenarios to run through the faster non-JavaScript Behat session.