feat: reorder activity data item columns#781
Open
anonymoususer72041 wants to merge 2 commits into
Open
Conversation
anonymoususer72041
changed the title
anonymoususer72041
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorders the
activitytable columns so thatdata_item_typeappears beforedata_item_id.The previous physical column order placed
data_item_idbeforedata_item_type, even though the ID is interpreted in the context of the type. The existingIDX_type_idindex already uses the more logical order ofdata_item_type, data_item_id, so this change aligns the table definition with that structure.For new installations, the base schema now defines
activity.data_item_typebeforeactivity.data_item_id. The related security test fixture was updated to keep the explicitINSERT INTO activity (...)column order and corresponding values consistent with the schema.For existing installations, a new install schema migration was added to move
activity.data_item_typedirectly afteractivity_id. The migration only changes the physical column position and does not alter data, indexes, column types, defaults, nullability or unrelated schema objects.