feat: make contact title optional#786
Open
anonymoususer72041 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the contact title field optional when creating or editing contacts.
The server-side validation no longer requires a contact title, while first name and last name remain required as before. The add and edit contact forms were also updated so the title field is no longer marked as mandatory and the contact form validation no longer blocks submissions with an empty title.
Motivation
Contact titles are not always known when adding or updating a contact.
Previously, users had to enter a placeholder value just to save the contact. With this change, contacts can be saved without a title when that information is unknown, while still allowing a title to be entered whenever it is available.