Repository navigation
fix(ci): select Node and native pnpm certificate validation releases - #25
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR pins CI and Pages to Node 24.22.1 and updates native pnpm and its lockfile records to 12.15.0. Example: GitHub Actions installs the build toolchain.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 3 items remain Keep this PR open: it provides useful security updates absent from main, and inspection found no introduced code defect. Priority: P1 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherGitHub Actions and the release-check script install development tools, consume locked dependencies, and produce verified WASM builds and the Pages site. flowchart TD
A[Repository pins] --> B[CI and Pages setup]
A --> C[Release check]
B --> D[Node and pnpm]
C --> D
D --> E[Dependency installation]
E --> F[Build and verification]
Technical reviewBest possible solution: Land the focused toolchain update after certificate-rejection qualification, preserving the explicitly recorded release-channel exception. Do we have a high-confidence way to reproduce the issue? Main's older pnpm selection is directly visible, and upstream Node documents the compromised-intermediate vulnerability; no incident-host reproduction was executed. Is this the best way to solve the issue? Consistent runtime and package-manager pins are a focused solution, with matching registry integrity values and successful exact-head CI. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against c8e93bed4a24. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: shipped entry point. SecurityNeeds attention: No introduced security defect was identified, but the changed TLS trust decisions require accessible qualification evidence. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 6:43 PM ET / 22:43 UTC. |
Build and CI tooling selected Node and native pnpm releases that trusted the compromised certificate authority keys. Preserve the Node24 lane while selecting24.22.1, and select qualified native pnpm12.15.0 with its normal regenerated lock.
Validation: full pnpm check passed on Node24.22.1/nativepnpm12.15.0:31tests, TypeScript, lint, docs build, formatting. Browser sample video was skipped because the WASM bundle was not present; no FFmpeg/WASM rebuild or browser E2E is claimed. Changed YAML parsed and fresh full-context review found no P0–P2 findings. Actual Linuxarm64 Node and nativepnpm incident-host rejection proofs are retained in the campaign.
The release-check workflow’s inline npm node24.16.0 wrapper remains an explicit package-channel wait:24.22.1 is not published through that channel. Existing published artifacts, Actions’ embedded runtime, and Cloudflare-hosted runtime remain separate owners’ updates. No deployment or release was performed.