Skip to content

chore(release): open 0.35.1 Unreleased - #972

Merged
steipete merged 1 commit into
mainfrom
chore/open-0.35.1-unreleased
Aug 10, 2026
Merged

chore(release): open 0.35.1 Unreleased#972
steipete merged 1 commit into
mainfrom
chore/open-0.35.1-unreleased

Conversation

@steipete

@steipete steipete commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

v0.35.0 published successfully, but job 8 ("Open next Unreleased PR") was skipped because job 7 (Homebrew handoff) failed on the known TAP_TOKEN 403. This restores the changelog closeout the release process expects.

No functional change.

The v0.35.0 unified run's 'Open next Unreleased PR' job was skipped because the
Homebrew handoff failed on the tap token, so the section was never created.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@clawsweeper

clawsweeper Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. P2 Normal priority bug or improvement with limited blast radius. labels Aug 9, 2026
@clawsweeper

clawsweeper Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs changes before merge. Reviewed August 9, 2026, 6:13 PM ET / 22:13 UTC.

ClawSweeper review

What this changes

The PR adds a 0.35.1 Unreleased section to the changelog after the previous release closeout was skipped.

Merge readiness

⚠️ Ready for maintainer review - 3 items remain

Keep open: this collaborator-authored PR restores only half of the required release closeout. The established workflow, documentation, and contract test require updating the embedded development version as well as opening the changelog section.

Priority: P2
Reviewed head: 7ddd06d41f3d85e9d1b5fa6b978668e6475d3111

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The patch is narrowly scoped but currently omits a required companion version update.
Proof confidence 🌊 off-meta tidepool Not applicable: This collaborator-authored release-maintenance change is validated by the checked-in release contract rather than external runtime proof.
Patch quality 🦐 gold shrimp (3/6) 1 actionable review finding remain.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This collaborator-authored release-maintenance change is validated by the checked-in release contract rather than external runtime proof.
Evidence reviewed 4 items Documented closeout contract: Release documentation requires both the next patch Unreleased section and internal/cmd/VERSION set to the released version with a -dev suffix.
Release helper and test: The checked-in helper writes ${tag}-dev to internal/cmd/VERSION, and its contract test asserts that value alongside the new changelog heading.
Branch omission: The PR head changes only CHANGELOG.md; current main still has v0.35.0 in internal/cmd/VERSION, so the required development-version update is absent.
Findings 1 actionable finding [P2] Restore the matching development-version update
Security None None.

How this fits together

The release closeout transitions a published gogcli version into the next development cycle. It updates release notes and the embedded version consumed by source builds and later release automation.

flowchart LR
A[Published release] --> B[Release closeout]
B --> C[Changelog section]
B --> D[Embedded development version]
C --> E[Next release notes]
D --> F[Source builds]
E --> G[Next release cycle]
F --> G
Loading

Before merge

  • Restore the matching development-version update (P2) - The release helper, its contract test, and the release guide all require internal/cmd/VERSION to become v0.35.0-dev alongside the next Unreleased section. This changelog-only patch leaves source builds reporting the already-published version.
  • Resolve merge risk (P1) - Merging the changelog-only change would leave source builds reporting the already-published v0.35.0 instead of the expected v0.35.0-dev development version.
  • Complete next step (P2) - A narrow mechanical repair can align this PR with the documented two-file release-closeout contract.

Findings

  • [P2] Restore the matching development-version update — CHANGELOG.md:3-6
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Release closeout files 1 of 2 required files changed The documented helper and contract test require both the changelog and embedded development-version updates.

Merge-risk options

Maintainer options:

  1. Restore the version update (recommended)
    Update internal/cmd/VERSION to v0.35.0-dev with the new changelog section, then validate the existing release-closeout contract.
Copy recommended automerge instruction
@clawsweeper automerge

Special instructions:
Update internal/cmd/VERSION to v0.35.0-dev alongside the existing changelog closeout, then run scripts/test-start-next-release.sh.

Technical review

Best possible solution:

Land the release closeout only after the changelog section and internal/cmd/VERSION are updated together according to the documented contract.

Do we have a high-confidence way to reproduce the issue?

Yes: comparing the current release helper and contract test with the PR diff proves the PR omits the required version update.

Is this the best way to solve the issue?

No: the changelog-only patch is not the established release-closeout solution; it must update the embedded version in the same change.

Full review comments:

  • [P2] Restore the matching development-version update — CHANGELOG.md:3-6
    The release helper, its contract test, and the release guide all require internal/cmd/VERSION to become v0.35.0-dev alongside the next Unreleased section. This changelog-only patch leaves source builds reporting the already-published version.
    Confidence: 0.99

Overall correctness: patch is incorrect
Overall confidence: 0.99

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 402def5041d6.

Labels

Label justifications:

  • P2: The defect is confined to release-cycle metadata but makes post-release source builds report the wrong version.
  • merge-risk: 🚨 compatibility: Existing source-build consumers would continue to see the published version after the next development cycle has opened.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🦐 gold shrimp.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: This collaborator-authored release-maintenance change is validated by the checked-in release contract rather than external runtime proof.

Evidence

Acceptance criteria:

  • [P1] scripts/test-start-next-release.sh.

What I checked:

  • Documented closeout contract: Release documentation requires both the next patch Unreleased section and internal/cmd/VERSION set to the released version with a -dev suffix. (docs/RELEASING.md:53, 402def5041d6)
  • Release helper and test: The checked-in helper writes ${tag}-dev to internal/cmd/VERSION, and its contract test asserts that value alongside the new changelog heading. (scripts/start-next-release.sh:52, 402def5041d6)
  • Branch omission: The PR head changes only CHANGELOG.md; current main still has v0.35.0 in internal/cmd/VERSION, so the required development-version update is absent. (CHANGELOG.md:3, 7ddd06d41f3d)
  • Feature provenance: Blame attributes the helper and contract-test lines that enforce the paired update to the current 0.35.0 release-preparation commit. (scripts/start-next-release.sh:52, 402def5041d6)

Likely related people:

  • steipete: Peter Steinberger authored the current release-preparation commit blamed for the helper and test that define this two-file closeout contract. (role: release-closeout behavior introducer and recent area contributor; confidence: high; commits: 402def5041d6; files: scripts/start-next-release.sh, scripts/test-start-next-release.sh, internal/cmd/VERSION)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Set internal/cmd/VERSION to v0.35.0-dev.
  • Run scripts/test-start-next-release.sh and include its result in the PR.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (9 earlier review cycles; latest 8 shown)
  • reviewed 2026-08-09T10:07:12.207Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T11:57:01.792Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T13:08:23.508Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T14:31:56.386Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T15:53:34.637Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T16:58:19.518Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T19:30:48.480Z sha 7ddd06d :: needs changes before merge. :: [P2] Update the embedded development version with the closeout
  • reviewed 2026-08-09T21:03:55.478Z sha 7ddd06d :: needs changes before merge. :: [P2] Restore the matching development-version update

@clawsweeper clawsweeper Bot added the merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. label Aug 9, 2026
@steipete
steipete merged commit e4e71c6 into main Aug 10, 2026
14 checks passed
@steipete
steipete deleted the chore/open-0.35.1-unreleased branch August 10, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant