Repository navigation
build(deps): secure and refresh terminal test tooling - #116
Conversation
Bumps the development group with 2 updates: [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt) and [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint). Updates `oxfmt` from 0.73.0 to 0.74.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.74.0/npm/oxfmt) Updates `oxlint` from 1.88.0 to 1.89.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.89.0/npm/oxlint) --- updated-dependencies: - dependency-name: oxfmt dependency-version: 0.74.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development - dependency-name: oxlint dependency-version: 1.89.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesUpdates oxfmt from 0.73.0 to 0.74.0 and the locked oxlint version from 1.88.0 to 1.89.0, including their platform bindings. Example: A contributor installs dependencies with the frozen lockfile and runs pnpm check.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open for landing: the tooling updates are absent from main, the changes are focused, and no actionable defect was found. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThese development tools read repository files and produce formatting and lint diagnostics through package scripts; they are separate from the published terminal runtime dependencies. flowchart LR
A[Package manifest] --> B[Frozen lockfile]
B --> C[Platform bindings]
C --> D[Formatter and linter]
E[Repository source] --> D
D --> F[Development checks]
Technical reviewBest possible solution: Land the focused tooling refresh through the existing dependency maintenance workflow. Do we have a high-confidence way to reproduce the issue? This is a dependency maintenance PR without a reported repository bug to reproduce; the version changes are directly verified in the pinned diff. Is this the best way to solve the issue? The manifest and lockfile update is the smallest complete refresh, preserves existing runtime and package-manager constraints, and has passing checks for the reviewed head. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 1d80a0d43d30. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 22, 2026, 1:27 PM ET / 17:27 UTC. |
|
Merged as fd1ff8f. PR CI/CodeQL passed, and every post-merge Linux, Windows, Xcode 27, browser-smoke, and CodeQL job passed: https://github.com/openclaw/libterminal/actions/runs/39946129914. The current-version (0.3.10), no-publication release rehearsal passed: https://github.com/openclaw/libterminal/actions/runs/39946130691. Remote validation also passed the full release check with 140 unit tests and 9 actual Ghostty/WASM browser tests, plus a zero-finding dependency audit. Final independent P0–P3 review was clean. The first extra audit exposed six existing Vite advisories; explicitly requiring patched Vite 8.3.5 fixed automatic peer selection and the repeated release checks passed. No runtime/API change, release, tag, or package-version bump. The cloud lease is stopped and the task worktree removed; main is clean. The separate Ghostty adoption issue #41 remains under its existing upstream hold. |
Refresh oxfmt, oxlint, and Playwright, align the Vitest ranges with their locked patch releases, and keep local/CI/release setup on the maintained pnpm 11 line at 11.28.4. Thanks @dependabot for the original formatter/linter update.
The release check uncovered six advisories in implicitly selected Vite test-server dependencies. Declare patched Vite 8.3.5 explicitly so peer resolution cannot select vulnerable 8.3.0–8.3.2 releases. Keep the two-day cooldown, patched Node CI versions, public exports, and pinned Ghostty runtime unchanged.
Validation: independent P0–P3 Codex review is clean. On AWS Crabbox, frozen pnpm 11.28.4 install,
pnpm run check:release(140 unit tests, 9 real Ghostty/WASM browser tests, build, portable type checks, lint, formatting, package checks), andpnpm audit --audit-level=lowall passed with zero advisories. Exact updated-head multi-platform CI remains required before merge.