Skip to content

build(deps): refresh native build CLI and Vitest patches - #29

Merged
steipete merged 1 commit into
mainfrom
s21/proc-safe-deps
Oct 26, 2026
Merged

steipete merged 1 commit into
mainfrom
s21/proc-safe-deps

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Update the N-API build CLI from 3.10.8 to 3.10.9 and Vitest from 5.0.3 to 5.0.5. Both patch releases are beyond the repository's 48-hour minimum release age. Package versions and runtime floors are unchanged.

Validation: the complete JavaScript check pipeline passed locally (pnpm lint, pnpm typecheck, pnpm build, pnpm test --maxWorkers=2, pnpm pack:check): 105 passed, 14 platform-native skips. Independent P0–P2 review completed without findings. Native platform qualification is provided by this PR's CI; release validation will use a dry run only.

@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T11:22:23.363019Z 307eb53 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 26, 2026
@clawsweeper

clawsweeper Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR upgrades @napi-rs/cli to 3.10.9 and Vitest to 5.0.5 with matching lockfile updates.

Example: A contributor installs development dependencies using the frozen lockfile.

  • Before: The checkout resolves @napi-rs/cli 3.10.8 and Vitest 5.0.3.
  • After: The checkout resolves @napi-rs/cli 3.10.9 and Vitest 5.0.5.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, consistent maintenance patch with no actionable findings; platform qualification is still running.
Proof confidence 🌊 off-meta tidepool Not applicable: The host identifies this as maintainer-authored maintenance outside the ordinary proof gate; reported local checks and exact-head CI support tool compatibility.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors remain on older development tool patches.
Reason: The host identifies maintainer-approved direction, and the small refresh preserves the public package contract.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored dependency refresh is absent from main, and the reviewed diff introduces no concrete correctness defect.

Priority: P3
Reviewed head: 307eb53906cf86ff4a5fa9d84a3ad0a3a88c741c

Before merge

None.

Findings

None.

Agent review details

How this fits together

The development manifest and lockfile select tools used by repository checks; published runtime exports and native platform package versions remain unchanged.

flowchart LR
 A[Development manifest] --> B[Frozen dependency installation]
 C[Dependency lockfile] --> B
 B --> D[Vitest checks]
 B --> E[Development tooling]
 D --> F[CI qualification]
Loading

Technical review

Best possible solution:

Retain the focused dependency update and use the existing CI qualification before landing.

Do we have a high-confidence way to reproduce the issue?

This maintenance PR alleges no owned runtime bug; inspection was read-only, and no builds or tests were executed.

Is this the best way to solve the issue?

The manifest and lockfile updates are consistent, preserve runtime floors and platform pins, and require no additional production machinery.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 52244652b89f.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned change and main comparison: The introduced diff changes only package.json and pnpm-lock.yaml; main retains the older tool versions, while optional platform dependencies retain all ten exact 0.4.2 pins. (package.json:118, 307eb53906cf)
  • Applicable repository policy: The full root policy excludes routine dependency refreshes from the changelog; no .agents directory supplies additional maintainer notes or a pr-simplify skill. (AGENTS.md:43, 307eb53906cf)
  • Current discussion and validation: The full body reports local JavaScript validation; discussion supplies no additional behavior artifact. Exact-head checks show 18 successes, four queued Darwin jobs, and two running FreeBSD ARM64 jobs, with no failed check. (307eb53906cf)
  • Feature history and ownership: Peter Steinberger's scaffold introduced the existing dependency choices, and subsequent release work retained them; Josh Avant's current-main toolchain hardening updated pnpm without changing these choices. (package.json:118, 52244652b89f)
  • Upstream release age: The upstream CLI 3.10.9 release was published on 2026-10-21, exceeding the repository's 48-hour minimum before this PR.
  • Upstream release age: The upstream Vitest 5.0.5 release was published on 2026-10-15, exceeding the repository's 48-hour minimum before this PR.

Likely related people:

  • Peter Steinberger: Raw commit 5852b3e adds package.json:78 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 5852b3e263bf; files: package.json)
  • Josh Avant: Raw commit 5224465 adds package.json:127 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 52244652b89f; files: package.json)

Labels

Label changes:

  • add P3: Routine development dependency maintenance with no demonstrated user-facing regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine development dependency maintenance with no demonstrated user-facing regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 26, 2026, 7:34 AM ET / 11:34 UTC.

@steipete

Copy link
Copy Markdown
Contributor Author

Local JavaScript checks and independent P0–P2 review passed. At head 307eb53, 23 of 24 hosted checks succeeded; the remaining Intel macOS Node 24 job is still running: https://github.com/openclaw/proc-safe/actions/runs/40314493448/job/121543561857.

Keeping this open rather than bypassing that native gate. No test was disabled or blindly rerun. The separate FreeBSD runtime-admission PR #28 remains held for patched-runtime qualification.

@steipete
steipete merged commit b08c97c into main Oct 26, 2026
23 of 24 checks passed
@steipete
steipete deleted the s21/proc-safe-deps branch October 26, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant