Repository navigation
build(deps): refresh native build CLI and Vitest patches - #29
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR upgrades @napi-rs/cli to 3.10.9 and Vitest to 5.0.5 with matching lockfile updates. Example: A contributor installs development dependencies using the frozen lockfile.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored dependency refresh is absent from main, and the reviewed diff introduces no concrete correctness defect. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe development manifest and lockfile select tools used by repository checks; published runtime exports and native platform package versions remain unchanged. flowchart LR
A[Development manifest] --> B[Frozen dependency installation]
C[Dependency lockfile] --> B
B --> D[Vitest checks]
B --> E[Development tooling]
D --> F[CI qualification]
Technical reviewBest possible solution: Retain the focused dependency update and use the existing CI qualification before landing. Do we have a high-confidence way to reproduce the issue? This maintenance PR alleges no owned runtime bug; inspection was read-only, and no builds or tests were executed. Is this the best way to solve the issue? The manifest and lockfile updates are consistent, preserve runtime floors and platform pins, and require no additional production machinery. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 52244652b89f. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 26, 2026, 7:34 AM ET / 11:34 UTC. |
|
Local JavaScript checks and independent P0–P2 review passed. At head 307eb53, 23 of 24 hosted checks succeeded; the remaining Intel macOS Node 24 job is still running: https://github.com/openclaw/proc-safe/actions/runs/40314493448/job/121543561857. Keeping this open rather than bypassing that native gate. No test was disabled or blindly rerun. The separate FreeBSD runtime-admission PR #28 remains held for patched-runtime qualification. |
Update the N-API build CLI from 3.10.8 to 3.10.9 and Vitest from 5.0.3 to 5.0.5. Both patch releases are beyond the repository's 48-hour minimum release age. Package versions and runtime floors are unchanged.
Validation: the complete JavaScript check pipeline passed locally (
pnpm lint,pnpm typecheck,pnpm build,pnpm test --maxWorkers=2,pnpm pack:check): 105 passed, 14 platform-native skips. Independent P0–P2 review completed without findings. Native platform qualification is provided by this PR's CI; release validation will use a dry run only.