Repository navigation
build(deps-dev): bump the development group with 2 updates - #50
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the development group with 2 updates: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [tsdown](https://github.com/rolldown/tsdown). Updates `@types/node` from 26.6.3 to 26.6.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `tsdown` from 0.22.14 to 0.23.0 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.0) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.6.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: development - dependency-name: tsdown dependency-version: 0.23.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed October 6, 2026, 11:37 PM ET / October 7, 2026, 03:37 UTC (Revision 4). ClawSweeper reviewWhat this changesUpdates development Node types to 26.6.4 and the package bundler to tsdown 0.23.0, including their locked dependencies. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 3 items remain Keep open: the prior Node 25 installation regression remains on the unchanged head. Current main intentionally retains compatible tooling and does not include the independent Node types update. Priority: P2 Review scores
Verification
How this fits togetherThe development toolchain builds the router's TypeScript source into ESM JavaScript and declarations for consumers. Dependency installation enforces Node engine requirements before contributors can build or validate the package. flowchart LR
A[Contributor Node version] --> C[Strict dependency installation]
B[Locked development dependencies] --> C
C --> D{Engine requirements satisfied}
D --> E[Router build and declarations]
D --> F[Installation rejected]
Before merge
Findings
Agent review detailsSecurityNone. Review metricsNone. Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep the Node types update while retaining the established Node 25-compatible bundler graph and strict engine enforcement. Do we have a high-confidence way to reproduce the issue? Yes, from source: frozen development installation on Node 25 encounters two incompatible dependency engine ranges under engineStrict. This review did not execute installation. Is this the best way to solve the issue? No: the grouped update violates the established Node support contract; preserving the compatible bundler while updating Node types is the narrow repair. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against f7320e4435a3. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles)
|
Update @types/node to 26.6.4 while retaining build and test dependencies that support the declared Node range. tsdown 0.23.0 and Vitest 5.0.3 reject Node 25 under strict engine checks despite passing the previous Node 22/24 matrix. Add Ubuntu Node 25 coverage and document that compatibility boundary. Supersedes the compatible update in #50; #50 and #51 have Node 25 engine blockers. Thanks @dependabot. Validation: Node 25.9.0 / pnpm 11.27.1 full package check, 58 tests, packed-package install/import, strict-engine rejection probes for both held upgrades, workflow YAML parsing, diff check, and independent Codex review. Exact-head CI passed all seven Node/OS jobs, workflow lint, and CodeQL: https://github.com/openclaw/uirouter/actions/runs/37598481727 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Thanks for the update. The compatible Closing this combined update because tsdown 0.23.0 excludes Node 25, which remains supported here. A clean Node 25.9.0 install with our strict engine policy fails with |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the development group with 2 updates: @types/node and tsdown.
Updates
@types/nodefrom 26.6.3 to 26.6.4Commits
Updates
tsdownfrom 0.22.14 to 0.23.0Release notes
Sourced from tsdown's releases.
... (truncated)
Commits
ced9a2cchore: release v0.23.0f5f9ea9docs: add Ember support guide (#1043)8ac89dcchore: upgrade Vitest to v596a4098feat: expose programmatic watch controls (#1062)61718d7chore: upgrade depsd04119cchore: upgrade deps55f89c5chore(deps): update pnpm to v12.1.0 (#1060)946224dfix: ignore optional dependencies in type definitions62f01cdchore: release v0.23.0-rc.1bf53f43fix(cli): camel-case nested flag keysDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions