Repository navigation
build(deps-dev): bump vitest from 4.1.11 to 5.0.4 - #59
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.4. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.4/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. What this changesThis PR upgrades the development test runner from Vitest 4.1.11 to 5.0.4 and refreshes its locked dependencies. Example: A contributor installs development dependencies on Node 25.9.0 with strict engine checks enabled.
Review scores
ProductKind: Maintenance · Worth it: No Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 3 items remain This PR breaks supported Node 25 development installs and contradicts the recorded decision to retain Vitest 4; repository policy does not permit automatic closure for this reason. Priority: P2 Before merge
Findings
Provenance
Tests
Agent review detailsHow this fits togetherVitest runs the router's development tests through pnpm; its dependency engine requirements are enforced during installation before CI can build, test, and validate the package. flowchart TD
A[Contributor or CI] --> B[pnpm frozen installation]
B --> C[Strict engine validation]
C --> D[Vitest dependency graph]
D --> E[Router behavior tests]
E --> F[Package quality gate]
Technical reviewBest possible solution: Retain Vitest 4.1.11 until an upgrade supports the existing Node range or a separate approved change revises that contract. Do we have a high-confidence way to reproduce the issue? The locked Vitest engine range excludes Node 25 under engineStrict, and the exact-head Node 25 job fails during installation while current main passes; no target code was executed during this review. Is this the best way to solve the issue? The proposed upgrade conflicts with the established compatibility contract and the explicit deferral recorded in #52 and #55. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 251c5f19a107. TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 14, 2026, 5:42 PM ET / 21:42 UTC. |
|
Closing this repeated incompatible major upgrade at reviewed head This follows the explicit maintainer decision to retain Vitest 4.1.11 while Node 25 is supported: #51 (comment). Reconsider when Vitest restores that compatibility or the repository deliberately changes its runtime contract. No engine enforcement or Node coverage is being removed. Thanks to Dependabot for the update. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps vitest from 4.1.11 to 5.0.4.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
6a11cf6chore: release v5.0.4 (#11554)58c86edchore(deps): update all non-major dependencies (#11550)0fa80f5fix(coverage): filenames containing brackets incorrectly showing as uncovered...bf04b9cfix(browser): run browser instances as workers (#11525)3e3624crefactor: resolve maxWorkers once in config (#11524)26642f7fix: respect root in projects (#11521)c06012afeat(experimental): add an option to cache dependencies instead of statically...4ef000afix(coverage):allowExternalfails to include uncovered files (#11513)1da6640feat: supporttest.ui.themeoption (#11499)b618afdfix(vm): bindthistomodule.exports(#11504)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)