Skip to content

build(deps-dev): bump vitest from 4.1.11 to 5.0.4 - #59

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/vitest-5.0.4
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/vitest-5.0.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 14, 2026

Copy link
Copy Markdown
Contributor

Bumps vitest from 4.1.11 to 5.0.4.

Release notes

Sourced from vitest's releases.

v5.0.4

   🚀 Features

   🐞 Bug Fixes

... (truncated)

Commits
  • 6a11cf6 chore: release v5.0.4 (#11554)
  • 58c86ed chore(deps): update all non-major dependencies (#11550)
  • 0fa80f5 fix(coverage): filenames containing brackets incorrectly showing as uncovered...
  • bf04b9c fix(browser): run browser instances as workers (#11525)
  • 3e3624c refactor: resolve maxWorkers once in config (#11524)
  • 26642f7 fix: respect root in projects (#11521)
  • c06012a feat(experimental): add an option to cache dependencies instead of statically...
  • 4ef000a fix(coverage): allowExternal fails to include uncovered files (#11513)
  • 1da6640 feat: support test.ui.theme option (#11499)
  • b618afd fix(vm): bind this to module.exports (#11504)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.4.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.4/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 5.0.4
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner October 14, 2026 21:29
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 14, 2026
@clawsweeper

clawsweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 14, 2026
@clawsweeper

clawsweeper Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codex review: blocked before merge.

What this changes

This PR upgrades the development test runner from Vitest 4.1.11 to 5.0.4 and refreshes its locked dependencies.

Example: A contributor installs development dependencies on Node 25.9.0 with strict engine checks enabled.

  • Before: Vitest 4.1.11 permits Node 25, and the current main Node 25 installation check passes.
  • After: Vitest 5.0.4 excludes Node 25, so installation fails before package checks run.

Review scores

Measure Result What it means
Overall readiness 🧂 unranked krab (1/6) The upgrade breaks an explicitly supported development runtime and contradicts the recorded compatibility decision.
Proof confidence 🌊 off-meta tidepool Not applicable: This Dependabot development-dependency PR is outside the ordinary contributor proof gate; CI provides supporting validation but exposes the Node 25 installation failure.
Patch quality 🧂 unranked krab (1/6) 1 actionable review finding remain.

Product

Kind: Maintenance · Worth it: No
User problem: Contributors receive a newer test runner, but the update prevents supported Node 25 development installs.
Reason: The recorded owner direction preserves Node 25 support and defers Vitest 5; this release retains the incompatible engine requirement.

Regression provenance

Possible regression — suspected (reviewed change). No predecessor PR is attributed.

Merge readiness

⛔ Blocked before merge - 3 items remain

This PR breaks supported Node 25 development installs and contradicts the recorded decision to retain Vitest 4; repository policy does not permit automatic closure for this reason.

Priority: P2
Reviewed head: 657322c312f7f8fcaefbaebf1e095efe8d46b813

Before merge

  • [P1] Preserve Node 25 compatibility when updating Vitest (P1) - Vitest 5.0.4 declares Node ^22.12.0 || ^24.0.0 || >=26.0.0, excluding Node 25, while this package declares ^22.18.0 || >=24.11.0 and enables engineStrict. Consequently, a supported Node 25 development install fails before any package checks; the exact-head Node 25 CI job already fails at Install dependencies, whereas current main passes. Retain Vitest 4.1.11 and its compatible lockfile graph rather than disabling engine checks or removing the Node 25 lane; the same compatibility decision is recorded in build(deps): refresh Node types and cover Node 25 installs #52.
  • Product: not worth merging - The recorded owner direction preserves Node 25 support and defers Vitest 5; this release retains the incompatible engine requirement.
  • Explain or restore the original intent of Vitest version and development-runtime compatibility - 8ddc83a: The tooling refresh adopted Vitest 4.1.11; later merged build(deps): refresh Node types and cover Node 25 installs #52 and build(deps): refresh compatible tooling and Node setup #55 deliberately retained it to preserve Node 25 installs.

Findings

  • [P1] [P1] Preserve Node 25 compatibility when updating Vitest — package.json:59

Provenance

Tests

  • Missing end-to-end proof: The Node 25 lane fails before tests run, so successful validation covers only the Node 22 and 24 lanes.
Agent review details

How this fits together

Vitest runs the router's development tests through pnpm; its dependency engine requirements are enforced during installation before CI can build, test, and validate the package.

flowchart TD
  A[Contributor or CI] --> B[pnpm frozen installation]
  B --> C[Strict engine validation]
  C --> D[Vitest dependency graph]
  D --> E[Router behavior tests]
  E --> F[Package quality gate]
Loading

Technical review

Best possible solution:

Retain Vitest 4.1.11 until an upgrade supports the existing Node range or a separate approved change revises that contract.

Do we have a high-confidence way to reproduce the issue?

The locked Vitest engine range excludes Node 25 under engineStrict, and the exact-head Node 25 job fails during installation while current main passes; no target code was executed during this review.

Is this the best way to solve the issue?

The proposed upgrade conflicts with the established compatibility contract and the explicit deferral recorded in #52 and #55.

Full review comments:

  • [P1] [P1] Preserve Node 25 compatibility when updating Vitest — package.json:59
    Vitest 5.0.4 declares Node ^22.12.0 || ^24.0.0 || >=26.0.0, excluding Node 25, while this package declares ^22.18.0 || >=24.11.0 and enables engineStrict. Consequently, a supported Node 25 development install fails before any package checks; the exact-head Node 25 CI job already fails at Install dependencies, whereas current main passes. Retain Vitest 4.1.11 and its compatible lockfile graph rather than disabling engine checks or removing the Node 25 lane; the same compatibility decision is recorded in build(deps): refresh Node types and cover Node 25 installs #52.
    Confidence: 1

Overall correctness: patch is incorrect
Overall confidence: 0.99

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 251c5f19a107.

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Labels

Label changes:

  • add P2: This development-tooling upgrade blocks supported contributor installations but does not change the published router runtime.
  • add merge-risk: 🚨 compatibility: Vitest 5.0.4 rejects Node 25 despite the repository explicitly supporting that development runtime.
  • add merge-risk: 🚨 automation: The changed dependency graph causes the existing Node 25 CI installation step to fail before package validation.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🌊 off-meta tidepool and patch quality is 🧂 unranked krab.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Label justifications:

  • P2: This development-tooling upgrade blocks supported contributor installations but does not change the published router runtime.
  • merge-risk: 🚨 compatibility: Vitest 5.0.4 rejects Node 25 despite the repository explicitly supporting that development runtime.
  • merge-risk: 🚨 automation: The changed dependency graph causes the existing Node 25 CI installation step to fail before package validation.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🌊 off-meta tidepool and patch quality is 🧂 unranked krab.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 14, 2026, 5:42 PM ET / 21:42 UTC.

@vincentkoc

Copy link
Copy Markdown
Member

Closing this repeated incompatible major upgrade at reviewed head 657322c312f7f8fcaefbaebf1e095efe8d46b813. Current main still supports and tests Node 25 with strict engine checks. vitest@5.0.4 requires ^22.12.0 || ^24.0.0 || >=26.0.0, excluding Node 25; the exact-head installation fails: https://github.com/openclaw/uirouter/actions/runs/38640630151/job/116114923300.

This follows the explicit maintainer decision to retain Vitest 4.1.11 while Node 25 is supported: #51 (comment). Reconsider when Vitest restores that compatibility or the repository deliberately changes its runtime contract. No engine enforcement or Node coverage is being removed. Thanks to Dependabot for the update.

@vincentkoc vincentkoc closed this Oct 15, 2026
@dependabot @github

dependabot Bot commented on behalf of github Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/vitest-5.0.4 branch October 15, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant