feat: enable EnableRemoteLinkPicker WOPI flag for Collabora Online#2663
Open
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Open
feat: enable EnableRemoteLinkPicker WOPI flag for Collabora Online#2663pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
Set EnableRemoteLinkPicker: true in CheckFileInfo response so Collabora Online exposes its "Smart Picker" UI for link insertion. Clicking it sends a UI_PickLink postMessage to the WOPI host, which is expected to reply with Action_InsertLink carrying the URL of the selected file. Follows the same pattern as the existing EnableInsertRemoteImage / EnableInsertRemoteFile flags. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
|
Contributor
Author
|
cc: @micbar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set EnableRemoteLinkPicker: true in CheckFileInfo response so
Collabora Online exposes its "Smart Picker" UI for link
insertion. Clicking it sends a UI_PickLink postMessage to the WOPI
host, which is expected to reply with Action_InsertLink carrying the
URL of the selected file. Follows the same pattern as the existing
EnableInsertRemoteImage / EnableInsertRemoteFile flags.
Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com
go test ./services/collaboration/pkg/connector/...passesWhen the flag is enabled, clicking the Smart Picker button in Collabora fires a
UI_PickLinkpostMessage to the WOPI host. The host opens its file picker and replies withAction_InsertLinkcarrying the selected document's URL (and an optionaltextlabel).The
textlabel is honored upstream since CollaboraOnline/online#15561 (MERGED) — older coolwsd simply falls back to the URL. SDK reference: https://sdk.collaboraonline.com/docs/advanced_integration.html#enableremotelinkpicker