fix(oidc): add override option for JWKS URI#2680
Draft
Den4200 wants to merge 1 commit intoopencloud-eu:mainfrom
Draft
fix(oidc): add override option for JWKS URI#2680Den4200 wants to merge 1 commit intoopencloud-eu:mainfrom
Den4200 wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
|
Member
|
@rhafer Do you have an opinion? IMHO this doesn't do any damage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR makes it so that admins can override the JWKS URI that is specified in the OIDC well-known configuration via an environment variable or config.
Related Issue
Motivation and Context
Microsoft Entra ID is currently incompatible with OpenCloud, as their v2 issuer returns a v1 token for the MS Graph API that is signed by their v1 JWKS instead of their v2 JWKS that is referenced in their well-known configuration. See the linked issue above for more details. This fix will allow Microsoft Entra ID to be used with OpenCloud.
How Has This Been Tested?
Types of changes
Checklist: