fix: include custom metadata in allprop PROPFIND response#696
Open
flash7777 wants to merge 1 commit into
Open
Conversation
The allprop handler only output known metadata keys (tags, audio, location, image, photo). Arbitrary custom metadata set via the Graph Metadata API was silently omitted. Now all non-empty custom metadata keys are included in the allprop response. This complements cs3org#693 which fixes explicit metadata key requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The allprop PROPFIND handler only outputs known metadata keys (tags, audio, location, image, photo). Arbitrary custom metadata set via the Graph Metadata API is silently omitted from the response.
Changes
propfind.goArbitraryMetadata.Metadataand include all non-empty custom keys in the allprop responseMotivation
Applications that store custom metadata (e.g.
oy.fileReference,oy.status) viaSetArbitraryMetadataexpect these values to appear in PROPFIND allprop responses. Without this fix, only explicit prop requests (fixed in #693) return custom metadata — allprop silently drops them.Relation to other PRs
Companion to #693 (explicit metadata key requests). Together they ensure custom metadata is always returned in PROPFIND responses, regardless of request style.
Test plan