feat: Introduce slot for customizing course tab navigation#1917
feat: Introduce slot for customizing course tab navigation#1917xitij2000 wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Adds a new plugin slot (`CourseTabsNavigationSlot`) to enable customization, modification, or hiding of the course tab navigation. Updated relevant components to integrate with the new slot.
d1f2907 to
c9693eb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1917 +/- ##
==========================================
+ Coverage 91.30% 91.32% +0.02%
==========================================
Files 344 346 +2
Lines 5774 5789 +15
Branches 1351 1386 +35
==========================================
+ Hits 5272 5287 +15
Misses 483 483
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall this looks great! I left a couple comments about the PropTypes -> .tsx conversion, once those are addressed this should be good to land!
|
@brian-smith-tcril I've applied the suggested changes. |
|
There are a few tests that don't set Once those are updated this should be good to land! |
Adds a new plugin slot (
CourseTabsNavigationSlot) to enable customization, modification, or hiding of the course tab navigation.