-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: consolidated pip-compile -> uv migration (all 5 stacked PRs, rebased onto master) #38915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
976bcef
8398493
3951ef3
3ba6641
f3aad4d
e438c12
599b970
ed5f8a5
138aafa
e495a60
d3f85f9
ed31316
9777414
362c94b
6d4d18a
a1d3ea1
1ac90a6
4ab40db
afdcc75
196f97c
1c592ea
9824895
4326dfd
91d8156
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,13 +39,26 @@ jobs: | |
| git fetch origin "$BASE_SHA" | ||
|
|
||
| # The ^"? is because git may quote weird file paths | ||
| if git diff --name-only "$BASE_SHA" | grep -P '^"?((requirements/)|(scripts/.*?/requirements/))'; then | ||
| # | ||
| # This still watches requirements/ because requirements/edx-sandbox | ||
| # (its own uv project) and the requirements/edx/*.txt compatibility | ||
| # exports still live there. A planned follow-up will remove the | ||
| # requirements/ folder entirely (see public-engineering#543), at | ||
| # which point this pattern will need updating again. | ||
| if git diff --name-only "$BASE_SHA" | grep -P '^"?((requirements/)|(scripts/.*?/requirements/)|(scripts/[^/]+/pyproject\.toml)|(scripts/[^/]+/uv\.lock)|(pyproject\.toml)|(uv\.lock))'; then | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should add a comment here, as this doesn’t seem to be a permanent solution. In the upcoming follow-up PRs, we plan to remove the requirements folder, so this will need to be updated again.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same fix applies here (duplicate thread) -- see 1c592ea. |
||
| echo "RELEVANT=true" >> "$GITHUB_ENV" | ||
| fi | ||
|
|
||
| - uses: actions/setup-python@v6 | ||
| - name: install system requirements | ||
| if: ${{ env.RELEVANT == 'true' }} | ||
| run: | | ||
| sudo apt-get update && sudo apt-get install libmysqlclient-dev libxmlsec1-dev | ||
|
|
||
|
farhan marked this conversation as resolved.
|
||
| - name: Install uv | ||
| if: ${{ env.RELEVANT == 'true' }} | ||
| uses: astral-sh/setup-uv@v9.0.0 | ||
| with: | ||
| enable-cache: true | ||
| python-version: '3.12' | ||
|
|
||
| - name: "Recompile requirements" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a comment here, as this doesn’t seem to be a permanent solution. In the upcoming follow-up PRs, we plan to remove the requirements folder, so this will need to be updated again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment explaining this is transitional (requirements/edx-sandbox + the compat .txt exports still live under requirements/, but a planned follow-up per public-engineering#543 removes the folder entirely, at which point this pattern needs updating again). See 1c592ea.