Use getDisplayMetrics() to find screen DPI on Android.#1604
Merged
Conversation
Contributor
|
I'd say it's safe to use |
Contributor
Author
|
A ok |
Contributor
Author
|
@player-03 done |
`getRealMetrics()` is now deprecated as well. It suggests using `getCurrentWindowMetrics()` instead, but that's new in SDK 30 and doesn't even contain DPI information. Whereas this function has been around since the start.
player-03
changed the title
getRealMetrics() to find screen DPI on Android.
player-03
changed the title
getRealMetrics() to find screen DPI on Android.getDisplayMetrics() to find screen DPI on Android.
Contributor
Author
|
I thought this won't be pushed, that's why I closed it .___. |
Member
|
I haven't looked at it personally yet, but sometimes it just takes us forever to completely vet some prs. If you're getting feedback, its typically a good sign. |
Contributor
Author
|
Ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title