Fix eventloop usage for haxe 5#2007
Conversation
|
I think this needs to be updated too: Line 470 in 17fe047 Also, this will have the same issue as the openfl dictionary size PR since haxe 5 preview 1 didn't have this updated api yet. |
8b7ee84 to
e55c2fb
Compare
|
Copying Josh's comment here so I can find it later:
|
|
Wait, I have a question, what about the warnings when using nightly Haxe version? |
|
If they're related to the event loop, we could add them to this PR, otherwise it would be a separate PR. |
|
@tobil4sk It got conflicted 💀 |
|
Is there anything development related blocking this merge? |
|
Nothing on our side AFAIK, just Josh's concern that Haxe might still make changes. |
|
Ok fair, no rush then. |
Haxe 5 nightlies have a new api for event loops: HaxeFoundation/haxe#12388
See the equivalent heaps patch: HeapsIO/heaps@d40f2d0#diff-c0fa4e889efa97012174175edcce85cc359792651eb5e7435d2f0c0ed26dec0a