Skip to content

Drop support for Python 3.11#2174

Merged
mattwthompson merged 10 commits into
mainfrom
no-py311
Apr 29, 2026
Merged

Drop support for Python 3.11#2174
mattwthompson merged 10 commits into
mainfrom
no-py311

Conversation

@mattwthompson
Copy link
Copy Markdown
Member

@mattwthompson mattwthompson commented Apr 24, 2026

Closes #2173

@mattwthompson

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (b56ac24) to head (031a885).
⚠️ Report is 1 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattwthompson mattwthompson marked this pull request as ready for review April 24, 2026 16:02
@mattwthompson mattwthompson requested a review from j-wags as a code owner April 24, 2026 16:02
@mattwthompson
Copy link
Copy Markdown
Member Author

mattwthompson commented Apr 28, 2026

The test suite is misconfigured, resulting in runs that take more than an hour to finish. This is fixed in #2170 which would make it feasible to debug failures here

@mattwthompson mattwthompson marked this pull request as draft April 28, 2026 19:13
@mattwthompson mattwthompson marked this pull request as ready for review April 28, 2026 21:25
mattwthompson
mattwthompson commented Apr 28, 2026
View reviewed changes
Comment thread openff/toolkit/typing/engines/smirnoff/parameters.py
j-wags
j-wags approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwthompson!

Comment thread openff/toolkit/typing/engines/smirnoff/parameters.py
j-wags
j-wags reviewed Apr 29, 2026
View reviewed changes
Comment thread docs/releasehistory.md Outdated
mattwthompson
mattwthompson commented Apr 29, 2026
View reviewed changes
Comment thread docs/releasehistory.md Outdated
@mattwthompson
Apply suggestions from code review
031a885 
Co-authored-by: Matt Thompson <matt.thompson@openforcefield.org>
@mattwthompson mattwthompson merged commit 6e2fc35 into main Apr 29, 2026
21 of 22 checks passed
@mattwthompson mattwthompson deleted the no-py311 branch April 29, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-wags j-wags j-wags approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.11

3 participants

@mattwthompson @j-wags