Bump Mypy#2181
Draft
mattwthompson wants to merge 4 commits into
Draft
Conversation
Member
mattwthompson
commented
May 14, 2026
mattwthompson
commented
- Tag issue being addressed
- Add tests
- Update docstrings/documentation, if applicable
- Lint codebase
- Update changelog
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates type-checking configuration to support a newer Mypy version.
Changes:
- Remove NumPy Mypy plugin configuration from
pyproject.toml - Add a Mypy ignore for a NetworkX node iteration typing issue
- Switch OpenEye dev env to install Mypy via pip (and update its pinned version)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adjusts Mypy configuration (removes NumPy plugin entry). |
| openff/toolkit/topology/molecule.py | Adds a Mypy suppression on a NetworkX nodes iteration. |
| devtools/conda-envs/openeye.yaml | Changes how Mypy is installed/pinned in the OpenEye conda env. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.