Add binding_hash conformance vectors - #611
Open
Math1987 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @alexolivier, I’m following up on these binding_hash conformance vectors for the Access Request and Approval Profile. The PR remains limited to informational vectors, a dependency free verifier, and the related documentation link. I would be glad to make any changes needed for review. |
Collaborator
|
Hey, thanks for the additions. We don't really have a precedent of having these scripts being referenced from a spec before. So I'm not sure how we approach this, given we don't want a published spec to point at something that can move if it just sits in a Git repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binding_hashconstructionsubject.properties.actremoval,binding_context_membersselection, absent versusnull, JCS number serialization, and array/item orderingCloses #556
Validation
node profiles/authzen-access-request-approval/test-vectors/verify-binding-hash-vectors.mjsmake -C profiles/authzen-access-request-approval test-vectorscanonicalize@3.0.0git diff --checkIPR
The OpenID Foundation Contribution Agreement has been signed and submitted.